diff options
| author | Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> | 2021-03-16 19:36:39 +0100 |
|---|---|---|
| committer | Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> | 2021-03-22 09:18:04 +0100 |
| commit | d171632faa9f563f47224e0f6214f8860ed7bcc4 (patch) | |
| tree | 1a817528568a6d8840199f132491314996f1ae16 /gdbserver/dll.h | |
| parent | 2aaf2ce843e4078b158cdfb61435217621ba1803 (diff) | |
| download | binutils-gdb-d171632faa9f563f47224e0f6214f8860ed7bcc4.tar.gz | |
gdbserver: convert the global dll list into a process_info field
The 'all_dlls' list is global. This would cause the complete dll list
to be reported for individual processes. Move the list into the
process_info struct.
Currently the dll list is used only by the win32-low target, which
does not support the multi-process feature. Therefore, it practically
does not matter whether the list is global or per-process. However,
there may be targets that are outside the binutils-gdb repo (e.g. we,
at Intel, have such a target) that have multi-process and use the dll
list. So, it makes sense to do the right thing.
gdbserver/ChangeLog:
2021-03-22 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* inferiors.h (struct process_info) <all_dlls, dlls_changed>: New
fields.
* dll.h (loaded_dll)
(unloaded_dll): Declare an overloaded version that takes a proc
parameter.
* dll.cc (loaded_dll)
(unloaded_dll): Implement the overloaded versions.
(clear_dlls): Clear all process' dll lists.
(all_dlls, dlls_changed): Remove the global variables.
* remote-utils.cc (prepare_resume_reply): Update to consider a dll
list per proc.
* server.cc (handle_qxfer_libraries): Ditto.
(handle_v_attach): Ditto.
(captured_main): Ditto.
Diffstat (limited to 'gdbserver/dll.h')
| -rw-r--r-- | gdbserver/dll.h | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/gdbserver/dll.h b/gdbserver/dll.h index 6707c52e440..2a29990d623 100644 --- a/gdbserver/dll.h +++ b/gdbserver/dll.h @@ -20,6 +20,8 @@ #include <list> +struct process_info; + struct dll_info { dll_info (const std::string &name_, CORE_ADDR base_addr_) @@ -30,11 +32,12 @@ struct dll_info CORE_ADDR base_addr; }; -extern std::list<dll_info> all_dlls; -extern int dlls_changed; - extern void clear_dlls (void); extern void loaded_dll (const char *name, CORE_ADDR base_addr); +extern void loaded_dll (process_info *proc, const char *name, + CORE_ADDR base_addr); extern void unloaded_dll (const char *name, CORE_ADDR base_addr); +extern void unloaded_dll (process_info *proc, const char *name, + CORE_ADDR base_addr); #endif /* GDBSERVER_DLL_H */ |