diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2015-07-22 03:35:47 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2015-07-22 03:37:50 -0700 |
| commit | cd78ea777c35c497fcc0f20d162789296dc0a44d (patch) | |
| tree | 02bc776750cce865c4b9f7007677b23035201bea /gold | |
| parent | bb854a36d192bfa6609da9e3b1342e33da445598 (diff) | |
| download | binutils-gdb-cd78ea777c35c497fcc0f20d162789296dc0a44d.tar.gz | |
Mark global with hidden attribute
GCC 5 will generate a relocation for protected symbol:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248
when compiling for a shared library. It is undefined to access protected
symbol in IFUNC selector function inside a shared library.
PR gold/18628
* testsuite/ifuncdep2.c (global): Change protected to hidden.
* testsuite/ifuncmod1.c (global): Likewise.
* testsuite/ifuncmod5.c (global): Likewise.
Diffstat (limited to 'gold')
| -rw-r--r-- | gold/ChangeLog | 7 | ||||
| -rw-r--r-- | gold/testsuite/ifuncdep2.c | 2 | ||||
| -rw-r--r-- | gold/testsuite/ifuncmod1.c | 2 | ||||
| -rw-r--r-- | gold/testsuite/ifuncmod5.c | 2 |
4 files changed, 10 insertions, 3 deletions
diff --git a/gold/ChangeLog b/gold/ChangeLog index cd52db08956..45daaa573a0 100644 --- a/gold/ChangeLog +++ b/gold/ChangeLog @@ -1,3 +1,10 @@ +2015-07-22 H.J. Lu <hongjiu.lu@intel.com> + + PR gold/18628 + * testsuite/ifuncdep2.c (global): Change protected to hidden. + * testsuite/ifuncmod1.c (global): Likewise. + * testsuite/ifuncmod5.c (global): Likewise. + 2015-07-22 Alan Modra <amodra@gmail.com> * aarch64.cc (try_fix_erratum_843419_optimized): Warning fix. diff --git a/gold/testsuite/ifuncdep2.c b/gold/testsuite/ifuncdep2.c index 758bae1932e..f2a11f175c8 100644 --- a/gold/testsuite/ifuncdep2.c +++ b/gold/testsuite/ifuncdep2.c @@ -2,7 +2,7 @@ #include "ifunc-sel.h" -int global __attribute__ ((visibility ("protected"))) = -1; +int global __attribute__ ((visibility ("hidden"))) = -1; static int one (void) diff --git a/gold/testsuite/ifuncmod1.c b/gold/testsuite/ifuncmod1.c index e3b37cb5ab0..8ee11f1448f 100644 --- a/gold/testsuite/ifuncmod1.c +++ b/gold/testsuite/ifuncmod1.c @@ -6,7 +6,7 @@ */ #include "ifunc-sel.h" -int global __attribute__ ((visibility ("protected"))) = -1; +int global __attribute__ ((visibility ("hidden"))) = -1; static int one (void) diff --git a/gold/testsuite/ifuncmod5.c b/gold/testsuite/ifuncmod5.c index 9a08e8cf53c..1fd815ba7be 100644 --- a/gold/testsuite/ifuncmod5.c +++ b/gold/testsuite/ifuncmod5.c @@ -1,7 +1,7 @@ /* Test STT_GNU_IFUNC symbols without direct function call. */ #include "ifunc-sel.h" -int global __attribute__ ((visibility ("protected"))) = -1; +int global __attribute__ ((visibility ("hidden"))) = -1; static int one (void) |