diff options
| author | Nick Clifton <nickc@redhat.com> | 2002-05-02 09:11:14 +0000 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2002-05-02 09:11:14 +0000 |
| commit | 6c1073c0ebb63d6754888c8708deb092cd166a72 (patch) | |
| tree | d2d49b1f6d61369fc8d98179f413a36663b168d3 | |
| parent | 83cf14480974d50a67041be0bd3bd4f67dbd2fa3 (diff) | |
| download | binutils-redhat-6c1073c0ebb63d6754888c8708deb092cd166a72.tar.gz | |
Do not convert a subtract of zero into an add of zero.
| -rw-r--r-- | gas/ChangeLog | 5 | ||||
| -rw-r--r-- | gas/config/tc-arm.c | 8 | ||||
| -rw-r--r-- | gas/testsuite/ChangeLog | 6 | ||||
| -rw-r--r-- | gas/testsuite/gas/arm/arm7t.d | 2 | ||||
| -rw-r--r-- | gas/testsuite/gas/arm/arm7t.s | 8 |
5 files changed, 26 insertions, 3 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index 76b97adf60..6244a87517 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2002-05-02 Nick Clifton <nickc@cambridge.redhat.com> + + * config/tc-arm.c (thumb_add_sub): Do not convert a subtract of + zero into an add of zero - it is not the same. + 2002-05-01 Arati Dikey <aratid@kpit.com> * tc-sh.c (get_specific): Generate warning if the same diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c index 162553f643..1370f13e5a 100644 --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -7433,11 +7433,11 @@ thumb_add_sub (str, subtract) int offset = inst.reloc.exp.X_add_number; if (subtract) - offset = -offset; + offset = - offset; if (offset < 0) { - offset = -offset; + offset = - offset; subtract = 1; /* Quick check, in case offset is MIN_INT. */ @@ -7447,7 +7447,9 @@ thumb_add_sub (str, subtract) return; } } - else + /* Note - you cannot convert a subtract of 0 into an + add of 0 because the carry flag is set differently. */ + else if (offset > 0) subtract = 0; if (Rd == REG_SP) diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog index 428b6a2045..6e552b7e11 100644 --- a/gas/testsuite/ChangeLog +++ b/gas/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2002-05-02 Nick Clifton <nickc@cambridge.redhat.com> + + * gas/arm/arm7t.s: Add thumb mode "sub r?, #0" and "add r?, #0". + * gas/arm/arm7t.d: Add expected results. (Make sure that the + subtract is not converted into an add). + 2002-04-23 H.J. Lu <hjl@gnu.org> * gas/mips/elempic.d: Use empic.l. diff --git a/gas/testsuite/gas/arm/arm7t.d b/gas/testsuite/gas/arm/arm7t.d index dc4993a0b5..87b388f5e6 100644 --- a/gas/testsuite/gas/arm/arm7t.d +++ b/gas/testsuite/gas/arm/arm7t.d @@ -66,3 +66,5 @@ Disassembly of section .text: [ ]*dc:.*fred 0+e0 <[^>]*> 0000c0de ? .* 0+e4 <[^>]*> 0000dead ? .* +0+e8 <[^>]*> 3800 sub r0, #0 +0+ea <[^>]*> 3000 add r0, #0 diff --git a/gas/testsuite/gas/arm/arm7t.s b/gas/testsuite/gas/arm/arm7t.s index d155752eed..f3251117d1 100644 --- a/gas/testsuite/gas/arm/arm7t.s +++ b/gas/testsuite/gas/arm/arm7t.s @@ -72,3 +72,11 @@ misc: .align .L2: .word fred + + .ltorg + .thumb + .global thumb_tests + .thumb_func +thumb_tests: + sub r0, #0 + add r0, #0 |