diff options
| author | Alan Modra <amodra@bigpond.net.au> | 2002-01-05 13:11:33 +0000 |
|---|---|---|
| committer | Alan Modra <amodra@bigpond.net.au> | 2002-01-05 13:11:33 +0000 |
| commit | b55d193279f3b0ae7753ac971187d99d3e0c85ee (patch) | |
| tree | 8dac30e26b88d5f265667992dafc5151d4e83f9e /bfd/hpux-core.c | |
| parent | 794df144ceeb173b140e2968ab1880cc3ebea97a (diff) | |
| download | binutils-redhat-b55d193279f3b0ae7753ac971187d99d3e0c85ee.tar.gz | |
* section.c (bfd_section_init): Remove unnecessary initialisations.
(bfd_section_list_clear): New function.
(bfd_section_list_remove, bfd_section_list_insert): New macros.
(_bfd_strip_section_from_output): Use them.
* coffcode.h (coff_set_alignment_hook): Likewise.
* elf32-mips.c (_bfd_mips_elf_final_link): Likewise.
* elf64-mips.c (mips_elf64_final_link): Likewise.
* elf64-mmix.c (mmix_elf_final_link): Likewise.
* sunos.c (sunos_add_dynamic_symbols): Likewise.
* xcofflink.c (_bfd_xcoff_bfd_final_link): Likewise.
* bfd-in2.h: Regenerate.
* netbsd-core.c (netbsd_core_file_p): Use bfd_make_section_anyway
rather than doing our own section handling. Clean up after errors
with bfd_release and bfd_section_list_clear. Handle unexpected
flags.
* aoutf1.h (sunos4_core_file_p): Likewise.
* aix386-core.c (aix386_core_file_p): Likewise.
* cisco-core.c (cisco_core_file_validate): Likewise.
* ptrace-core.c (ptrace_unix_core_file_p): Likewise.
* trad-core.c (trad_unix_core_file_p): Likewise.
* hppabsd-core.c (hppabsd_core_core_file_p): Clean up after errors
with bfd_release and bfd_section_list_clear.
* hpux-core.c (hpux_core_core_file_p): Likewise.
* irix-core.c (irix_core_core_file_p): Likewise.
* lynx-core.c (lynx_core_file_p): Likewise.
* osf-core.c (osf_core_core_file_p): Likewise.
* rs6000-core.c (rs6000coff_core_p): Likewise.
* sco5-core.c (sco5_core_file_p): Likewise.
Diffstat (limited to 'bfd/hpux-core.c')
| -rw-r--r-- | bfd/hpux-core.c | 19 |
1 files changed, 13 insertions, 6 deletions
diff --git a/bfd/hpux-core.c b/bfd/hpux-core.c index e39df79d6c..a8360228eb 100644 --- a/bfd/hpux-core.c +++ b/bfd/hpux-core.c @@ -1,5 +1,5 @@ /* BFD back-end for HP/UX core files. - Copyright 1993, 1994, 1996, 1998, 1999, 2001 + Copyright 1993, 1994, 1996, 1998, 1999, 2001, 2002 Free Software Foundation, Inc. Written by Stu Grossman, Cygnus Support. Converted to back-end form by Ian Lance Taylor, Cygnus SUpport @@ -246,7 +246,7 @@ hpux_core_core_file_p (abfd) core_header.len, (int) &proc_info - (int) & proc_info.hw_regs, 2)) - return NULL; + goto fail; } else { @@ -259,7 +259,7 @@ hpux_core_core_file_p (abfd) core_header.len, (int) &proc_info - (int) & proc_info.hw_regs, 2)) - return NULL; + goto fail; } /* We always make one of these sections, for every thread. */ sprintf (secname, ".reg/%d", core_kernel_thread_id (abfd)); @@ -268,7 +268,7 @@ hpux_core_core_file_p (abfd) core_header.len, (int) &proc_info - (int) & proc_info.hw_regs, 2)) - return NULL; + goto fail; } core_signal (abfd) = proc_info.sig; if (bfd_seek (abfd, (file_ptr) core_header.len, SEEK_CUR) != 0) @@ -286,7 +286,7 @@ hpux_core_core_file_p (abfd) if (!make_bfd_asection (abfd, ".data", SEC_ALLOC + SEC_LOAD + SEC_HAS_CONTENTS, core_header.len, core_header.addr, 2)) - return NULL; + goto fail; bfd_seek (abfd, (file_ptr) core_header.len, SEEK_CUR); good_sections++; @@ -302,7 +302,8 @@ hpux_core_core_file_p (abfd) unknown_sections++; break; - default: return 0; /*unrecognized core file type */ + default: + goto fail; /*unrecognized core file type */ } } @@ -320,6 +321,12 @@ hpux_core_core_file_p (abfd) abfd->filename); return abfd->xvec; + + fail: + bfd_release (abfd, core_hdr (abfd)); + core_hdr (abfd) = NULL; + bfd_section_list_clear (abfd); + return NULL; } static char * |