Touches most files in bfd/, so likely will be blamed for everything..

o  bfd_read and bfd_write lose an unnecessary param and become
   bfd_bread and bfd_bwrite.

o  bfd_*alloc now all take a bfd_size_type arg, and will error if
   size_t is too small.  eg. 32 bit host, 64 bit bfd, verrry big files
   or bugs in linker scripts etc.

o  file_ptr becomes a bfd_signed_vma.  Besides matching sizes with
   various other types involved in handling sections, this should make
   it easier for bfd to support a 64 bit off_t on 32 bit hosts that
   provide it.

o  I've made the H_GET_* and H_PUT_* macros (which invoke bfd_h_{get,put}_*)
   generally available.  They now cast their args to bfd_vma and
   bfd_byte * as appropriate, which removes a swag of casts from the
   source.

o  Bug fixes to bfd_get8, aix386_core_vec, elf32_h8_relax_section, and
   aout-encap.c.

o  Zillions of formatting and -Wconversion fixes.

1 files changed, 16 insertions, 12 deletions

diff --git a/bfd/rs6000-core.c b/bfd/rs6000-core.c
index 08b17ee947..e6405f962c 100644
--- a/bfd/rs6000-core.c
+++ b/bfd/rs6000-core.c
@@ -258,24 +258,28 @@ read_hdr (bfd *abfd, CoreHdr *core)
 {
   bfd_size_type size;
 
-  if (bfd_seek (abfd, 0, SEEK_SET) != 0)
+  if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0)
     return false;
 
   /* Read the leading portion that old and new core dump structures have in
      common.  */
-  if (bfd_read (core, CORE_COMMONSZ, 1, abfd) != CORE_COMMONSZ)
+  size = CORE_COMMONSZ;
+  if (bfd_bread (core, size, abfd) != size)
     return false;
 
   /* Read the trailing portion of the structure.  */
-  size = CORE_NEW (*core) ? sizeof (core->new) : sizeof (core->old)
-    - CORE_COMMONSZ;
-  return bfd_read ((char *) core + CORE_COMMONSZ, size, 1, abfd) == size;
+  if (CORE_NEW (*core))
+    size = sizeof (core->new);
+  else
+    size = sizeof (core->old);
+  size -= CORE_COMMONSZ;
+  return bfd_bread ((char *) core + CORE_COMMONSZ, size, abfd) == size;
 }
 
 static asection *
 make_bfd_asection (abfd, name, flags, _raw_size, vma, filepos)
      bfd *abfd;
-     CONST char *name;
+     const char *name;
      flagword flags;
      bfd_size_type _raw_size;
      bfd_vma vma;
@@ -424,7 +428,7 @@ rs6000coff_core_p (abfd)
 
   /* Allocate core file header.  */
   size = CORE_NEW (core) ? sizeof (core.new) : sizeof (core.old);
-  tmpptr = (char *) bfd_zalloc (abfd, size);
+  tmpptr = (char *) bfd_zalloc (abfd, (bfd_size_type) size);
   if (!tmpptr)
     return NULL;
 
@@ -545,7 +549,7 @@ rs6000coff_core_p (abfd)
       {
 	if (bfd_seek (abfd, c_loader, SEEK_SET) != 0)
 	  return NULL;
-	if (bfd_read (&ldinfo, size, 1, abfd) != size)
+	if (bfd_bread (&ldinfo, size, abfd) != size)
 	  return NULL;
 
 	if (proc64)
@@ -590,7 +594,7 @@ rs6000coff_core_p (abfd)
 	    bfd_vma vminfo_addr;
 
 	    size = CORE_NEW (core) ? sizeof (vminfo.new) : sizeof (vminfo.old);
-	    if (bfd_read (&vminfo, size, 1, abfd) != size)
+	    if (bfd_bread (&vminfo, size, abfd) != size)
 	      return NULL;
 
 	    if (CORE_NEW (core))
@@ -652,14 +656,14 @@ rs6000coff_core_file_matches_executable_p (core_bfd, exec_bfd)
     return false;
 
   alloc = 100;
-  path = bfd_malloc (alloc);
+  path = bfd_malloc ((bfd_size_type) alloc);
   if (path == NULL)
     return false;
   s = path;
 
   while (1)
     {
-      if (bfd_read (s, 1, 1, core_bfd) != 1)
+      if (bfd_bread (s, (bfd_size_type) 1, core_bfd) != 1)
 	{
 	  free (path);
 	  return false;
@@ -672,7 +676,7 @@ rs6000coff_core_file_matches_executable_p (core_bfd, exec_bfd)
 	  char *n;
 
 	  alloc *= 2;
-	  n = bfd_realloc (path, alloc);
+	  n = bfd_realloc (path, (bfd_size_type) alloc);
 	  if (n == NULL)
 	    {
 	      free (path);