diff options
| author | Nick Clifton <nickc@redhat.com> | 2013-10-09 16:17:23 +0000 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2013-10-09 16:17:23 +0000 |
| commit | 5b2e229ad7f6aa90ae3a9a5793c9843f395399df (patch) | |
| tree | a624fcf4254955567c90a94b0a08b74734c78d16 /binutils | |
| parent | ea2cdc5e88987833401968a721cbc42faedc264f (diff) | |
| download | binutils-redhat-5b2e229ad7f6aa90ae3a9a5793c9843f395399df.tar.gz | |
PR binutils/16024
* objdump.c (usage): Mark as a no-return function.
(main): Add comment explaining why a break statement is not
needed.
Diffstat (limited to 'binutils')
| -rw-r--r-- | binutils/ChangeLog | 5 | ||||
| -rw-r--r-- | binutils/objdump.c | 11 |
2 files changed, 10 insertions, 6 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 2bebf99999..48d3f0ba25 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,5 +1,10 @@ 2013-10-09 Nick Clifton <nickc@redhat.com> + PR binutils/16024 + * objdump.c (usage): Mark as a no-return function. + (main): Add comment explaining why a break statement is not + needed. + * dwarf.c (add64): New function. (read_and_display_attr_value): Add CU offset in to the value displayed for a DW_AT_ref8 attribute. diff --git a/binutils/objdump.c b/binutils/objdump.c index 89efc155fb..37962cb157 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -1,7 +1,5 @@ /* objdump.c -- dump information about an object file. - Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, - 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, - 2012, 2013 Free Software Foundation, Inc. + Copyright 1990-2013 Free Software Foundation, Inc. This file is part of GNU Binutils. @@ -193,6 +191,7 @@ static const struct objdump_private_desc * const objdump_private_vectors[] = NULL }; +static void usage (FILE *, int) ATTRIBUTE_NORETURN; static void usage (FILE *stream, int status) { @@ -3657,15 +3656,15 @@ main (int argc, char **argv) dump_section_headers = TRUE; seenflag = TRUE; break; - case 'H': - usage (stdout, 0); - seenflag = TRUE; case 'v': case 'V': show_version = TRUE; seenflag = TRUE; break; + case 'H': + usage (stdout, 0); + /* No need to set seenflag or to break - usage() does not return. */ default: usage (stderr, 1); } |