diff options
| author | Cary Coutant <ccoutant@google.com> | 2008-04-17 00:14:36 +0000 |
|---|---|---|
| committer | Cary Coutant <ccoutant@google.com> | 2008-04-17 00:14:36 +0000 |
| commit | a35c5992a31bf48fb7de56ddd7606a8913e0153c (patch) | |
| tree | 194ee1b5ce9b3f73ddc57987ca20e56abc0e7cec /gold/symtab.h | |
| parent | 0bd253fc225e59f3a2c6046c1bacdf2b57fcaea4 (diff) | |
| download | binutils-redhat-a35c5992a31bf48fb7de56ddd7606a8913e0153c.tar.gz | |
* symtab.h (Symbol::is_strong_undefined): Removed unused function.
(Symbol::needs_plt_entry): Allow weak undefined symbols.
(Symbol::needs_dynamic_reloc): Allow weak undefined symbols when
building shared libraries.
* testsuite/Makefile.am (weak_undef_nonpic_test): New target.
(weak_undef_file1_nonpic.o, weak_undef_file2_nonpic.o)
(weak_undef_lib_nonpic.so, alt/weak_undef_lib_nonpic.so): New targets.
* testsuite/Makefile.in: Rebuild.
* testsuite/weak_undef.h: New file.
* testsuite/weak_undef_file1.cc: Add extra test cases.
* testsuite/weak_undef_file2.cc: Likewise.
* testsuite/weak_undef_test.cc: Likewise.
Diffstat (limited to 'gold/symtab.h')
| -rw-r--r-- | gold/symtab.h | 22 |
1 files changed, 9 insertions, 13 deletions
diff --git a/gold/symtab.h b/gold/symtab.h index fb5828b2e0..64e7a388f4 100644 --- a/gold/symtab.h +++ b/gold/symtab.h @@ -414,15 +414,6 @@ class Symbol && this->shndx() == elfcpp::SHN_UNDEF); } - // Return whether this is a strong (i.e., not weak) undefined symbol. - bool - is_strong_undefined() const - { - return (this->source_ == FROM_OBJECT - && this->binding() != elfcpp::STB_WEAK - && this->shndx() == elfcpp::SHN_UNDEF); - } - // Return whether this is an absolute symbol. bool is_absolute() const @@ -478,7 +469,7 @@ class Symbol return (!parameters->doing_static_link() && this->type() == elfcpp::STT_FUNC && (this->is_from_dynobj() - || this->is_strong_undefined() + || this->is_undefined() || this->is_preemptible())); } @@ -506,9 +497,14 @@ class Symbol if (parameters->doing_static_link()) return false; - // A reference to a weak undefined symbol or to an absolute symbol - // does not need a dynamic relocation. - if (this->is_weak_undefined() || this->is_absolute()) + // A reference to a weak undefined symbol from an executable should be + // statically resolved to 0, and does not need a dynamic relocation. + // This matches gnu ld behavior. + if (this->is_weak_undefined() && !parameters->options().shared()) + return false; + + // A reference to an absolute symbol does not need a dynamic relocation. + if (this->is_absolute()) return false; // An absolute reference within a position-independent output file |