diff options
| author | Bastien Nocera <hadess@hadess.net> | 2016-05-09 12:47:17 +0200 |
|---|---|---|
| committer | Bastien Nocera <hadess@hadess.net> | 2016-05-13 12:39:16 +0200 |
| commit | 7f09161c41f9d0f737b3a92ffde2651f06216f82 (patch) | |
| tree | 18fd31ade63c2d95d90cbf8c2a4175294e2b1731 | |
| parent | 372cfdb681cdbf06ca2873cd15db7b412bedb780 (diff) | |
| download | bluez-tools-7f09161c41f9d0f737b3a92ffde2651f06216f82.tar.gz | |
bt-agent: Implement AuthorizeService security
We shouldn't allow just anyone to connect to our Bluetooth services.
Only allow paired devices to connect. Trusted devices are already allowed
to connect without calling out the agent.
| -rw-r--r-- | src/lib/agent-helper.c | 30 |
1 files changed, 28 insertions, 2 deletions
diff --git a/src/lib/agent-helper.c b/src/lib/agent-helper.c index c9f86dc..cbd8b44 100644 --- a/src/lib/agent-helper.c +++ b/src/lib/agent-helper.c @@ -49,8 +49,34 @@ static void _bt_agent_method_call_func(GDBusConnection *connection, const gchar if (g_strcmp0(method_name, "AuthorizeService") == 0) { - // Return void - g_dbus_method_invocation_return_value(invocation, NULL); + GError *error = NULL; + Device *device_obj = device_new(g_variant_get_string(g_variant_get_child_value(parameters, 0), NULL)); + const char *uuid = g_variant_get_string(g_variant_get_child_value(parameters, 1), NULL); + + if (_interactive) + g_print("Device: %s (%s) for UUID %s\n", device_get_alias(device_obj, &error), device_get_address(device_obj, &error), uuid); + + if (error) + { + g_critical("Failed to get remote device's MAC address: %s", error->message); + g_error_free(error); + g_dbus_method_invocation_return_dbus_error(invocation, "org.bluez.Error.Rejected", "Internal error occurred"); + return; + } + + if (device_get_paired (device_obj, &error)) + { + g_dbus_method_invocation_return_value(invocation, NULL); + } + else if (error) + { + g_dbus_method_invocation_return_dbus_error(invocation, "org.bluez.Error.Rejected", "Internal error occurred"); + g_error_free (error); + } + else + { + g_dbus_method_invocation_return_dbus_error(invocation, "org.bluez.Error.Rejected", "Service authorization rejected"); + } } else if (g_strcmp0(method_name, "Cancel") == 0) { |