summaryrefslogtreecommitdiff
path: root/android/avrcp-lib.c
diff options
context:
space:
mode:
authorSzymon Janc <szymon.janc@tieto.com>2015-03-28 21:56:08 +0100
committerSzymon Janc <szymon.janc@tieto.com>2015-03-28 22:04:11 +0100
commitf5222f068f6fba49e3d38d61731d32136b76f105 (patch)
tree426e1ef7682b755371203943069fbcb21d58127b /android/avrcp-lib.c
parentf257d27bd2b1444894be656a1c4c665f9f8d0bcc (diff)
downloadbluez-f5222f068f6fba49e3d38d61731d32136b76f105.tar.gz
android/avrcp-lib: Fix not initializing attributes
While parsing sttribute list attrs were not initialized with media item id. Conditional jump or move depends on uninitialised value(s) at 0x427850: handle_get_element_attributes_rsp (avrcp.c:1140) by 0x423DFC: get_element_attributes_rsp (avrcp-lib.c:2543) by 0x42039C: session_cb (avctp.c:789) by 0x36A7E492A5: g_main_context_dispatch (in /usr/lib64/ libglib-2.0.so.0.3800.2) by 0x36A7E49627: ??? (in /usr/lib64/libglib-2.0.so.0.3800.2) by 0x36A7E49A39: g_main_loop_run (in /usr/lib64/ libglib-2.0.so.0.3800.2) by 0x40ACB5: main (main.c:661)
Diffstat (limited to 'android/avrcp-lib.c')
-rw-r--r--android/avrcp-lib.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/android/avrcp-lib.c b/android/avrcp-lib.c
index e404494be..4edfd0e9b 100644
--- a/android/avrcp-lib.c
+++ b/android/avrcp-lib.c
@@ -2447,10 +2447,12 @@ static int parse_attribute_list(uint8_t *params, uint16_t params_len,
if (item->len > 0) {
text[i] = g_strndup(item->data, item->len);
+ attrs[i] = item->attr;
params_len -= item->len;
params += item->len;
} else {
text[i] = NULL;
+ attrs[i] = 0;
}
}