diff options
| author | Luiz Augusto von Dentz <luiz.von.dentz@intel.com> | 2016-08-25 16:50:30 +0300 |
|---|---|---|
| committer | Luiz Augusto von Dentz <luiz.von.dentz@intel.com> | 2016-08-25 17:02:22 +0300 |
| commit | a1c86eba31c4b60827d59af38320b4b8a71ce019 (patch) | |
| tree | a934ddd5e8bfd55515b117155d4e9be57cc7e17a /emulator/smp.c | |
| parent | 854b003fecb23426bc976e38d612ab8716b15179 (diff) | |
| download | bluez-a1c86eba31c4b60827d59af38320b4b8a71ce019.tar.gz | |
build: Fix checking result of sizeof instead of memcmp
This can be easily spot when building with clang:
emulator/smp.c:373:53: error: size argument in 'memcmp' call is a comparison
[-Werror,-Wmemsize-comparison]
if (memcmp(conn->pcnf, confirm, sizeof(conn->pcnf) != 0)) {
tools/smp-tester.c:596:53: error: size argument in 'memcmp' call is a comparison
[-Werror,-Wmemsize-comparison]
if (memcmp(data->pcnf, confirm, sizeof(data->pcnf) != 0)) {
Diffstat (limited to 'emulator/smp.c')
| -rw-r--r-- | emulator/smp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/emulator/smp.c b/emulator/smp.c index 40836cfbb..c30de3666 100644 --- a/emulator/smp.c +++ b/emulator/smp.c @@ -370,7 +370,7 @@ static bool verify_random(struct smp_conn *conn, const uint8_t rnd[16]) conn->ra_type, conn->ra, confirm)) return false; - if (memcmp(conn->pcnf, confirm, sizeof(conn->pcnf) != 0)) { + if (memcmp(conn->pcnf, confirm, sizeof(conn->pcnf)) != 0) { printf("Confirmation values don't match\n"); return false; } |