diff options
| author | Isak Westin <isak.westin@loytec.com> | 2022-10-06 16:59:23 +0200 |
|---|---|---|
| committer | Brian Gix <brian.gix@intel.com> | 2022-10-06 13:56:21 -0700 |
| commit | c1f1a49aeb1518fa8a808e107573399acab2bd86 (patch) | |
| tree | a6b3b10eb7092aabcfa80fd016d40c2c6e2ad3ed /mesh | |
| parent | 95bf980b015ee4cb549568d18dd4db6c3f74aa4a (diff) | |
| download | bluez-c1f1a49aeb1518fa8a808e107573399acab2bd86.tar.gz | |
mesh: provisionee: Handle unknown PDUs
If an unknown PDU is received during provisioning, the provisioning
should fail with "Invalid PDU".
Diffstat (limited to 'mesh')
| -rw-r--r-- | mesh/prov-acceptor.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/mesh/prov-acceptor.c b/mesh/prov-acceptor.c index f579a143b..ac257b170 100644 --- a/mesh/prov-acceptor.c +++ b/mesh/prov-acceptor.c @@ -399,6 +399,12 @@ static void acp_prov_rx(void *user_data, const uint8_t *data, uint16_t len) l_debug("Provisioning packet received type: %2.2x (%u octets)", type, len); + if (type >= L_ARRAY_SIZE(expected_pdu_size)) { + l_error("Unknown PDU type: %2.2x", type); + fail.reason = PROV_ERR_INVALID_PDU; + goto failure; + } + if (type == prov->previous) { l_error("Ignore repeated %2.2x packet", type); return; @@ -408,8 +414,7 @@ static void acp_prov_rx(void *user_data, const uint8_t *data, uint16_t len) goto failure; } - if (type >= L_ARRAY_SIZE(expected_pdu_size) || - len != expected_pdu_size[type]) { + if (len != expected_pdu_size[type]) { l_error("Expected PDU size %d, Got %d (type: %2.2x)", len, expected_pdu_size[type], type); fail.reason = PROV_ERR_INVALID_FORMAT; |