diff options
| author | Vikrampal Yadav <vikram.pal@samsung.com> | 2014-11-12 14:23:15 +0530 |
|---|---|---|
| committer | Luiz Augusto von Dentz <luiz.von.dentz@intel.com> | 2014-11-12 17:20:47 +0200 |
| commit | 84f3de0df83ffaca5a2a916fdc86ef0a0888fa1f (patch) | |
| tree | 2aa0daf84f288a6dbeb936a29751153ac78fa6e2 /monitor/avctp.c | |
| parent | 56dacf9b908e81d6d10b1be6d31258b10cf1a278 (diff) | |
| download | bluez-84f3de0df83ffaca5a2a916fdc86ef0a0888fa1f.tar.gz | |
monitor: Fix AVRCP GetElementAttributes
AttributeValueLength can be 0 which would lead to use uninitialized
memory, with this changes it now workds properly:
AVCTP Control: Response: type 0x00 label 0 PID 0x110e
AV/C: Stable: address 0x48 opcode 0x00
Subunit: Panel
Opcode: Vendor Dependent
Company ID: 0x001958
AVRCP: GetElementAttributes pt Single len 0x0019
AttributeCount: 0x03
Attribute: 0x00000001 (Title)
CharsetID: 0x006a (UTF-8)
AttributeValueLength: 0x0000
AttributeValue:
Attribute: 0x00000002 (Artist)
CharsetID: 0x006a (UTF-8)
AttributeValueLength: 0x0000
AttributeValue:
Attribute: 0x00000003 (Album)
CharsetID: 0x006a (UTF-8)
AttributeValueLength: 0x0000
AttributeValue:
Diffstat (limited to 'monitor/avctp.c')
| -rw-r--r-- | monitor/avctp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/monitor/avctp.c b/monitor/avctp.c index 11dc9b2cd..af91eccc5 100644 --- a/monitor/avctp.c +++ b/monitor/avctp.c @@ -1122,7 +1122,7 @@ response: num = avrcp_continuing.num; if (avrcp_continuing.size > 0) { - char attrval[UINT8_MAX]; + char attrval[UINT8_MAX] = {0}; uint16_t size; uint8_t idx; @@ -1157,7 +1157,7 @@ response: uint32_t attr; uint16_t charset, attrlen; uint8_t idx; - char attrval[UINT8_MAX]; + char attrval[UINT8_MAX] = {0}; if (!l2cap_frame_get_be32(frame, &attr)) goto failed; |