summaryrefslogtreecommitdiff
path: root/profiles
diff options
context:
space:
mode:
authorLuiz Augusto von Dentz <luiz.von.dentz@intel.com>2022-08-30 16:55:32 -0700
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>2022-08-31 15:24:39 -0700
commit49b8c5901584eab77af40f8ad19779747b4506d6 (patch)
tree3690842d154a03c2f1f8445d5b3f00d82f038c7b /profiles
parenta84aa0e6e5e7cd94804386eaf09d430d1cf8e692 (diff)
downloadbluez-49b8c5901584eab77af40f8ad19779747b4506d6.tar.gz
media: Fix scan-build warnings
This fixes the following warnings: profiles/audio/media.c:1465:6: warning: 8th function call argument is an uninitialized value if (media_endpoint_create(adapter, sender, path, uuid, delay_reporting, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/media.c:3012:3: warning: Use of memory after it is freed release_endpoint(adapter->endpoints->data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/media.c:3015:3: warning: Use of memory after it is freed media_player_destroy(adapter->players->data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Diffstat (limited to 'profiles')
-rw-r--r--profiles/audio/media.c21
1 files changed, 16 insertions, 5 deletions
diff --git a/profiles/audio/media.c b/profiles/audio/media.c
index a7fa85d60..c9328ab9b 100644
--- a/profiles/audio/media.c
+++ b/profiles/audio/media.c
@@ -1440,7 +1440,7 @@ static DBusMessage *register_endpoint(DBusConnection *conn, DBusMessage *msg,
gboolean delay_reporting = FALSE;
uint8_t codec = 0;
struct bt_bap_pac_qos qos = {};
- uint8_t *capabilities;
+ uint8_t *capabilities = NULL;
int size = 0;
int err;
@@ -3005,14 +3005,25 @@ static const GDBusPropertyTable media_properties[] = {
static void path_free(void *data)
{
struct media_adapter *adapter = data;
+ GSList *l;
queue_destroy(adapter->apps, app_free);
- while (adapter->endpoints)
- release_endpoint(adapter->endpoints->data);
+ for (l = adapter->endpoints; l;) {
+ struct media_endpoint *endpoint = l->data;
+
+ l = g_slist_next(l);
+
+ release_endpoint(endpoint);
+ }
+
+ for (l = adapter->players; l;) {
+ struct media_player *mp = l->data;
+
+ l = g_slist_next(l);
- while (adapter->players)
- media_player_destroy(adapter->players->data);
+ media_player_destroy(mp);
+ }
adapters = g_slist_remove(adapters, adapter);