diff options
| author | Dagan Martinez <martinez.dagan@gmail.com> | 2021-09-26 13:00:39 -0400 |
|---|---|---|
| committer | Luiz Augusto von Dentz <luiz.von.dentz@intel.com> | 2021-09-27 10:34:41 -0700 |
| commit | 7d4f408839ea727fdea9c4522953b3eb8c00e4c2 (patch) | |
| tree | b098e86290730981054b3dad4678496bf825558f /src/gatt-database.c | |
| parent | 5c0857665b0357401a27b121d9af78690eb23da5 (diff) | |
| download | bluez-7d4f408839ea727fdea9c4522953b3eb8c00e4c2.tar.gz | |
gatt: remove superfluous extended properties
BlueZ contained superfluous properties that not only did nothing of
value, but needlessly created CEP descriptors for any characteristic
with a secure/encrypted/authenticated flag applied to it.
This actually deviated from the spec(Bluetooth core 5.3, 3.3.3.1) by
setting the reserved bits in the CEPD.
Diffstat (limited to 'src/gatt-database.c')
| -rw-r--r-- | src/gatt-database.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/gatt-database.c b/src/gatt-database.c index 99c95f2d6..1f7ce5f02 100644 --- a/src/gatt-database.c +++ b/src/gatt-database.c @@ -1656,27 +1656,21 @@ static bool parse_chrc_flags(DBusMessageIter *array, uint8_t *props, *ext_props |= BT_GATT_CHRC_EXT_PROP_WRITABLE_AUX; } else if (!strcmp("encrypt-read", flag)) { *props |= BT_GATT_CHRC_PROP_READ; - *ext_props |= BT_GATT_CHRC_EXT_PROP_ENC_READ; *perm |= BT_ATT_PERM_READ | BT_ATT_PERM_READ_ENCRYPT; } else if (!strcmp("encrypt-write", flag)) { *props |= BT_GATT_CHRC_PROP_WRITE; - *ext_props |= BT_GATT_CHRC_EXT_PROP_ENC_WRITE; *perm |= BT_ATT_PERM_WRITE | BT_ATT_PERM_WRITE_ENCRYPT; } else if (!strcmp("encrypt-authenticated-read", flag)) { *props |= BT_GATT_CHRC_PROP_READ; - *ext_props |= BT_GATT_CHRC_EXT_PROP_AUTH_READ; *perm |= BT_ATT_PERM_READ | BT_ATT_PERM_READ_AUTHEN; } else if (!strcmp("encrypt-authenticated-write", flag)) { *props |= BT_GATT_CHRC_PROP_WRITE; - *ext_props |= BT_GATT_CHRC_EXT_PROP_AUTH_WRITE; *perm |= BT_ATT_PERM_WRITE | BT_ATT_PERM_WRITE_AUTHEN; } else if (!strcmp("secure-read", flag)) { *props |= BT_GATT_CHRC_PROP_READ; - *ext_props |= BT_GATT_CHRC_EXT_PROP_AUTH_READ; *perm |= BT_ATT_PERM_READ | BT_ATT_PERM_READ_SECURE; } else if (!strcmp("secure-write", flag)) { *props |= BT_GATT_CHRC_PROP_WRITE; - *ext_props |= BT_GATT_CHRC_EXT_PROP_AUTH_WRITE; *perm |= BT_ATT_PERM_WRITE | BT_ATT_PERM_WRITE_SECURE; } else if (!strcmp("authorize", flag)) { *req_prep_authorization = true; |