summaryrefslogtreecommitdiff
path: root/docs/changelog.rst
diff options
context:
space:
mode:
authorBraedon Vickers <braedon.vickers@gmail.com>2020-04-17 19:42:23 +0800
committerMarcel Hellkamp <marc@gsites.de>2020-12-31 17:01:02 +0100
commitf796498aaaaf2bc110efd494d4036d48999b1a61 (patch)
tree609c4635e928fbd4e97d3ec2b94158b631486c8e /docs/changelog.rst
parent2243ab241a4a3f05160d22dc42f054a824c426dd (diff)
downloadbottle-f796498aaaaf2bc110efd494d4036d48999b1a61.tar.gz
Don't re-raise critical errors that occur while handling an error
This logic was added to satisfy pep-3333, where the error handling section says application authors should "never trap errors raised by start_response when exc_info is being provided". However, this appears to be intended to prevent applications from catching exc_info being re-raised by start_response(), which happens when an application tries to send an error response (includes exc_info), but can't as output has already been written to the client. These exceptions should be thrown up to the server so it can abort the connection, not caught by the application. In this case, the start_response() call in question may be an error response, but it's always the first call to start_response(), so should never re-raise exc_info in this way. As such, the special handling is unnecessary.
Diffstat (limited to 'docs/changelog.rst')
0 files changed, 0 insertions, 0 deletions