diff options
| author | David Sterba <dsterba@suse.cz> | 2015-06-11 00:46:30 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.cz> | 2015-06-11 00:46:30 +0200 |
| commit | c848046eb984fcbeeb78d681bf483aefbb35a013 (patch) | |
| tree | 73089fe97e851ebb914c4fb10925a57eb160b156 /cmds-replace.c | |
| parent | 4647ab887a592516841f74fa47586771bbcad81b (diff) | |
| download | btrfs-progs-c848046eb984fcbeeb78d681bf483aefbb35a013.tar.gz | |
btrfs-progs: print error within test_dev_for_mkfs
The error string buffer passed as an argument is of a fixed size, though
we could print up to PATH_MAX + something bytes. Print the error message
directly.
Signed-off-by: David Sterba <dsterba@suse.cz>
Diffstat (limited to 'cmds-replace.c')
| -rw-r--r-- | cmds-replace.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/cmds-replace.c b/cmds-replace.c index 75b131b..85365e3 100644 --- a/cmds-replace.c +++ b/cmds-replace.c @@ -142,7 +142,6 @@ static int cmd_start_replace(int argc, char **argv) int do_not_background = 0; int mixed = 0; DIR *dirstream = NULL; - char estr[100]; /* check test_dev_for_mkfs() for error string size*/ while ((c = getopt(argc, argv, "Brf")) != -1) { switch (c) { @@ -256,11 +255,10 @@ static int cmd_start_replace(int argc, char **argv) start_args.start.srcdevid = 0; } - ret = test_dev_for_mkfs(dstdev, force_using_targetdev, estr); - if (ret) { - fprintf(stderr, "%s", estr); + ret = test_dev_for_mkfs(dstdev, force_using_targetdev); + if (ret) goto leave_with_error; - } + fddstdev = open(dstdev, O_RDWR); if (fddstdev < 0) { fprintf(stderr, "Unable to open %s\n", dstdev); |