diff options
| author | Abderrahim Kitouni <akitouni@gnome.org> | 2018-10-28 12:32:22 +0100 |
|---|---|---|
| committer | Abderrahim Kitouni <a.kitouni@gmail.com> | 2018-11-13 09:37:07 +0000 |
| commit | e8bc5515c5fbc82b4c6501bab35e3878911e001b (patch) | |
| tree | f9dd44a386bd117b6fb87208e2f505b5245c6f90 | |
| parent | e55a9703f9567953ee5675da4725940c08ec90eb (diff) | |
| download | buildstream-abderrahim/cmake-variable-types.tar.gz | |
plugins/elements/cmake.yaml: always specify variable typesabderrahim/cmake-variable-types
cmake sometimes misinterprets relative paths as relative to the current directory
if this is not specified. See freedesktop-sdk/freedesktop-sdk#431
adjust tests/format/variables.py accordingly.
| -rw-r--r-- | buildstream/plugins/elements/cmake.yaml | 2 | ||||
| -rw-r--r-- | tests/format/variables.py | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/buildstream/plugins/elements/cmake.yaml b/buildstream/plugins/elements/cmake.yaml index 0fb2e715a..ba20d7ce6 100644 --- a/buildstream/plugins/elements/cmake.yaml +++ b/buildstream/plugins/elements/cmake.yaml @@ -19,7 +19,7 @@ variables: cmake-args: | -DCMAKE_INSTALL_PREFIX:PATH="%{prefix}" \ - -DCMAKE_INSTALL_LIBDIR=%{lib} %{cmake-extra} %{cmake-global} %{cmake-local} + -DCMAKE_INSTALL_LIBDIR:PATH="%{lib}" %{cmake-extra} %{cmake-global} %{cmake-local} cmake: | diff --git a/tests/format/variables.py b/tests/format/variables.py index 26bb3db98..46e22d0e6 100644 --- a/tests/format/variables.py +++ b/tests/format/variables.py @@ -20,7 +20,7 @@ DATA_DIR = os.path.join( ('autotools.bst', 'make-install', "make -j1 DESTDIR=\"/buildstream-install\" install"), ('cmake.bst', 'cmake', "cmake -B_builddir -H\".\" -G\"Unix Makefiles\" " + "-DCMAKE_INSTALL_PREFIX:PATH=\"/usr\" \\\n" + - "-DCMAKE_INSTALL_LIBDIR=lib "), + "-DCMAKE_INSTALL_LIBDIR:PATH=\"lib\" "), ('distutils.bst', 'python-install', "python3 ./setup.py install --prefix \"/usr\" \\\n" + "--root \"/buildstream-install\""), @@ -46,7 +46,7 @@ def test_defaults(cli, datafiles, tmpdir, target, varname, expected): ('autotools.bst', 'make-install', "make -j1 DESTDIR=\"/custom/install/root\" install"), ('cmake.bst', 'cmake', "cmake -B_builddir -H\".\" -G\"Ninja\" " + "-DCMAKE_INSTALL_PREFIX:PATH=\"/opt\" \\\n" + - "-DCMAKE_INSTALL_LIBDIR=lib "), + "-DCMAKE_INSTALL_LIBDIR:PATH=\"lib\" "), ('distutils.bst', 'python-install', "python3 ./setup.py install --prefix \"/opt\" \\\n" + "--root \"/custom/install/root\""), |