Remove pycodestyle

All the formatting-related warnings from `pycodestyle` are covered by
Black, and almost all of the remaining ones are covered by `pylint`.
Based on that, remove `pycodestyle` so that we don't have to maintain
another set of configuration.

More details on warnings/errors covered by `pycodestyle` below.

---

Here's the big list of pycodestyle error/warning codes:
https://pycodestyle.readthedocs.io/en/latest/intro.html#error-codes. They are
broken down into following categories:

1. Indentation
2. Whitespace
3. Blank line
4. Import
5. Line Length
6. Runtime
7. Deprecation warning
8. Statement

Out of the above, 1-5 are purely formatting related so we don't needd to care
about them. 6 is runtime issues like syntax error that are hard to miss (even
mypy will complain about these). 7 is about deprecation warnings. Half of them
don't apply to us since we only support Python 3.5+ and the other half is
covered by `pylint`.

That leaves us with the "E7*" codes, that pycodestyle groups under "Statement"
heading. After verifying each of them, the only ones that is really not covered
by either Black or Pylint is the following:

*  E731   do not assign a lambda expression, use a def

This sole check does not seem worth keeping another tool.

4 files changed, 0 insertions, 8 deletions

diff --git a/requirements/dev-requirements.in b/requirements/dev-requirements.in
index 8b871073b..cbf44c470 100644
--- a/requirements/dev-requirements.in
+++ b/requirements/dev-requirements.in
@@ -1,5 +1,4 @@
 pylint
-pycodestyle
 pytest >= 3.9
 pytest-datafiles >= 2.0
 pytest-env
diff --git a/requirements/dev-requirements.txt b/requirements/dev-requirements.txt
index c4930181e..bd8449978 100644
--- a/requirements/dev-requirements.txt
+++ b/requirements/dev-requirements.txt
@@ -1,5 +1,4 @@
 pylint==2.3.1
-pycodestyle==2.5.0
 pytest==5.1.2
 pytest-datafiles==2.0
 pytest-env==0.6.2
diff --git a/setup.cfg b/setup.cfg
index eb61e352c..363758652 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -23,11 +23,6 @@ markers =
     remoteexecution: run test only if --remote-execution option is specified
 xfail_strict=True
 
-[pycodestyle]
-max-line-length = 119
-ignore = E129,E125,W504,W605
-exclude = .git/**,.tox/**,.eggs/**,build/**,doc/source/conf.py,src/buildstream/_fuse/fuse.py,src/buildstream/_protos/**/*py,tmp/**
-
 [mypy]
 files = src
 warn_unused_configs = True
diff --git a/tox.ini b/tox.ini
index d8fa3e984..bd07e9e6c 100644
--- a/tox.ini
+++ b/tox.ini
@@ -131,7 +131,6 @@ commands_pre =
     {envpython} setup.py build_ext --inplace
 
 commands =
-    pycodestyle {posargs}
     pylint {posargs: src tests}
 deps =
     -rrequirements/requirements.txt