diff options
author | Benjamin Schubert <contact@benschubert.me> | 2020-05-07 22:06:03 +0100 |
---|---|---|
committer | bst-marge-bot <marge-bot@buildstream.build> | 2020-05-11 16:27:12 +0000 |
commit | db2039fe2f333bc33342b4168910b7ed0a626bbd (patch) | |
tree | 388347936e06e19b8e93941b38046f456e4ee733 /src/buildstream/_includes.py | |
parent | 8797ab18b5fe247fcf1409e1bde4dfe0037149eb (diff) | |
download | buildstream-db2039fe2f333bc33342b4168910b7ed0a626bbd.tar.gz |
lint: Stop using mutable objects for default arguments
Diffstat (limited to 'src/buildstream/_includes.py')
-rw-r--r-- | src/buildstream/_includes.py | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/buildstream/_includes.py b/src/buildstream/_includes.py index b9a1c0d22..2ecb70a31 100644 --- a/src/buildstream/_includes.py +++ b/src/buildstream/_includes.py @@ -42,7 +42,7 @@ class Includes: # current_loader (Loader): Use alternative loader (for junction files) # only_local (bool): Whether to ignore junction files # process_project_options (bool): Whether to process options from current project - def _process(self, node, *, included=set(), current_loader=None, only_local=False, process_project_options=True): + def _process(self, node, *, included=None, current_loader=None, only_local=False, process_project_options=True): if current_loader is None: current_loader = self._loader @@ -69,8 +69,11 @@ class Includes: # only_local (bool): Whether to ignore junction files # process_project_options (bool): Whether to process options from current project def _process_node( - self, node, *, included=set(), current_loader=None, only_local=False, process_project_options=True + self, node, *, included=None, current_loader=None, only_local=False, process_project_options=True ): + if included is None: + included = set() + includes_node = node.get_node("(@)", allowed_types=[ScalarNode, SequenceNode], allow_none=True) if includes_node: @@ -172,7 +175,7 @@ class Includes: # only_local (bool): Whether to ignore junction files # process_project_options (bool): Whether to process options from current project def _process_value( - self, value, *, included=set(), current_loader=None, only_local=False, process_project_options=True + self, value, *, included=None, current_loader=None, only_local=False, process_project_options=True ): value_type = type(value) |