diff options
author | Bundlerbot <bot@bundler.io> | 2018-10-16 03:08:58 +0000 |
---|---|---|
committer | SHIBATA Hiroshi <hsbt@ruby-lang.org> | 2018-12-11 09:30:00 +0900 |
commit | af44d914ee4e872599d73fc13e86f1d2c139c49d (patch) | |
tree | 0aeed34dd7b98d21c186cd2e55e6f29836ea1396 | |
parent | 5fb389d49a1bfe89f711beb51681276d7ced418e (diff) | |
download | bundler-af44d914ee4e872599d73fc13e86f1d2c139c49d.tar.gz |
Merge #6740
6740: Removed win32-open3 workaround. r=colby-swandale a=hsbt
### What was the end-user problem that led to this PR?
`win32-open3` gem was required Ruby 1.8 with Windows environment. Because RubyInstaller2 only provides the version of Ruby 2.1+.
### What is your fix for the problem, implemented in this PR?
Removed needless workaround.
Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
(cherry picked from commit 6063718bc6c77b6a16621741f94866d6555f4cee)
(cherry picked from commit ca4837445a672ae002c4bc0f5dceed31750423f9)
-rw-r--r-- | spec/spec_helper.rb | 11 | ||||
-rw-r--r-- | spec/support/helpers.rb | 2 |
2 files changed, 2 insertions, 11 deletions
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 90a88fac5b..21a9a5a050 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -46,17 +46,6 @@ end require "bundler" -# Require the correct version of popen for the current platform -if RbConfig::CONFIG["host_os"] =~ /mingw|mswin/ - begin - require "win32/open3" - rescue LoadError - abort "Run `gem install win32-open3` to be able to run specs" - end -else - require "open3" -end - Dir["#{File.expand_path("../support", __FILE__)}/*.rb"].each do |file| file = file.gsub(%r{\A#{Regexp.escape File.expand_path("..", __FILE__)}/}, "") require file unless file.end_with?("hax.rb") diff --git a/spec/support/helpers.rb b/spec/support/helpers.rb index d64b3923d5..d14ac20cae 100644 --- a/spec/support/helpers.rb +++ b/spec/support/helpers.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require "open3" + module Spec module Helpers def reset! |