summaryrefslogtreecommitdiff
path: root/lib/bundler/version.rb
diff options
context:
space:
mode:
authorThe Bundler Bot <bot@bundler.io>2018-09-18 23:53:18 +0000
committerThe Bundler Bot <bot@bundler.io>2018-09-18 23:53:18 +0000
commit63fd4f3f1f93238c762eab84718605221b138aaa (patch)
tree156ca44bc6d73a33b10f515935bcbb5e19da8872 /lib/bundler/version.rb
parentc0f8ce3434d6774e3229bcef4b85309b57ebac2e (diff)
parentc72a0946e65a298071fb3d38e9146e6c4b6dba02 (diff)
downloadbundler-auto.tar.gz
Auto merge of #6702 - bundler:better_force_to_redownload_transition, r=indirectauto
Better `--force` to `--redownload` transition ### What was the end-user problem that led to this PR? The problem was. that, while trying to run `bundle install --force` today, I was getting the error `unknown switch --force` error, and I was not sure what was causing it and what I needed to do to fix it. Also, running `bundle install --help` would show `--force` as a supported option, so that would make things even more confusing. ### What was your diagnosis of the problem? My diagnosis was that: * A lot of removal/renaming of options in bundler 2 are artificially linked to the `forget_cli_options` switch. To me, those changes even though they are related (stopping rememebering cli options prompted us to actually remove some unnecessary ones), they are independent, so it's not straighforward to find out that it's the `forget_cli_options` setting causing this rename to be in place. * We should show a helpful deprecation message instead of a hard error, so the transition is easier for users. * We should update the commands help to document newer instead of deprecated options. * The `bundle update` command has an equivalent `--force` option that should be renamed too for sanity. ### What is your fix for the problem, implemented in this PR? My fix to the above problems is to: * Always keep the `--force` alias, independently of whether the `forget_cli_options` is set or not. * Show a deprecation message when `--force` is used in bundler 2, but still keep it working as before. * Update the commands help to use `--redownload`. * Make the equivalent changes to the `bundle update` ### Why did you choose this fix out of the possible options? I chose this fix because it seems like the more user friendly way going forward in my opinion.
Diffstat (limited to 'lib/bundler/version.rb')
0 files changed, 0 insertions, 0 deletions