test: explicitly handle image formats in buffer_diff_core

In practice, the A and B images may be any mixture of RGB24 and
ARGB32 formats, so this change accepts all combinations of these
types, and converts the pixel values to a common (ARGB32) format
as needed.

Some of the newly added test failures are cases where the image
output is RGB24, but the matching reference image is ARGB32 with
noticeable transparency. Some of the newly passing tests are cases
where the unused 'alpha' channel of an RGB24 image was not equal
to 0xff, and the previous code had incorrectly used this channel
in max_diff calculations.

1 files changed, 36 insertions, 64 deletions

diff --git a/.gitlab-ci/ignore-xcb-window-rgb24.txt b/.gitlab-ci/ignore-xcb-window-rgb24.txt
index 26df57963..1ecea73ed 100644
--- a/.gitlab-ci/ignore-xcb-window-rgb24.txt
+++ b/.gitlab-ci/ignore-xcb-window-rgb24.txt
@@ -1,16 +1,15 @@
-arc-looping-dash
-bug-51910
+a1-clip-fill-rule
+alpha-similar
+big-empty-box
+big-empty-triangle
+big-little-box
+bitmap-font
+bug-431
 bug-spline
-caps-05
-caps-1
-caps-2
-caps-joins-05
-caps-joins-1
-caps-joins-2
-clear-source
+clip-device-offset
+clip-fill-rule-pixel-aligned
 clip-operator
-clip-text
-coverage-abutting
+clip-unbounded
 coverage-column-triangles
 coverage-intersecting-quads
 coverage-intersecting-triangles
@@ -18,99 +17,72 @@ coverage-rectangles
 coverage-row-triangles
 coverage-triangles
 culled-glyphs
+device-offset
+device-offset-positive
 extended-blend-alpha-mask
-fallback
+fill-empty
 fill-image
-filter-bilinear-extents
-font-matrix-translation
-ft-show-glyphs-positioning
-ft-show-glyphs-table
+ft-color-font
 ft-text-vertical-layout-type1
-ft-text-vertical-layout-type3
-glyph-cache-pressure
+gradient-alpha
+gradient-constant-alpha
+gradient-zero-stops
+gradient-zero-stops-mask
 halo
 halo-transform
-inverse-text
-linear-gradient
-linear-gradient-subset
-mask
-mask-transformed-image
-mask-transformed-similar
-operator-alpha-alpha
-operator-clear
+image-surface-source
+linear-gradient-one-stop
+mask-ctm
+mask-surface-ctm
+nil-surface
 operator-source
 overlapping-boxes
-overlapping-dash-caps
-overlapping-glyphs
-partial-clip-text-bottom
-partial-clip-text-left
-partial-coverage-reference
-partial-coverage-three-quarter-reference
+pass-through
+pdf-surface-source
+pixman-downscale-best-24
+pixman-rotate
+ps-surface-source
 push-group
 push-group-color
 radial-outer-focus
 record1414x-fill-alpha
 record1414x-self-intersecting
-record1414x-text-transform
 record2x-fill-alpha
 record2x-paint-alpha-clip-mask
-record90-fill-alpha
 record90-paint-alpha-clip
 record90-paint-alpha-solid-clip
 record90-self-intersecting
-recordflip-fill-alpha
 recordflip-paint-alpha-clip-mask
 recordflip-self-intersecting
 recordflip-whole-fill-alpha
 recordflip-whole-paint-alpha-clip-mask
 recordflip-whole-self-intersecting
-recording-surface-extend-none
 recording-surface-extend-pad
-recording-surface-extend-reflect
-recording-surface-extend-repeat
-recording-surface-over
-recording-surface-source
 record-neg-extents-bounded
 record-neg-extents-unbounded
+record-replay-extend-none
 record-replay-extend-pad
 record-replay-extend-reflect
 record-replay-extend-repeat
 record-self-intersecting
-reflected-stroke
 rotated-clip
-select-font-face
-show-glyphs-advance
-show-text-current-point
+scale-source-surface-paint
+set-source
 simple-edge
-smask
-smask-fill
-smask-image-mask
-smask-mask
-smask-paint
-smask-stroke
-smp-glyph
+source-surface-scale-paint
 stroke-clipped
 stroke-image
-subsurface
-subsurface-scale
-surface-pattern-operator
-surface-pattern-scale-up
-text-antialias-gray
+subsurface-outside-target
 text-antialias-subpixel
 text-antialias-subpixel-bgr
 text-antialias-subpixel-rgb
 text-antialias-subpixel-vbgr
 text-antialias-subpixel-vrgb
-text-glyph-range
 text-pattern
 text-rotate
-text-transform
+thin-lines
 tighten-bounds
-trap-clip
-twin
-twin-antialias-gray
 twin-antialias-none
-twin-antialias-subpixel
 unantialiased-shapes
-unbounded-operator
-xcomposite-projection
+xcb-surface-source
+xlib-surface-source