test: explicitly handle image formats in buffer_diff_core

In practice, the A and B images may be any mixture of RGB24 and
ARGB32 formats, so this change accepts all combinations of these
types, and converts the pixel values to a common (ARGB32) format
as needed.

Some of the newly added test failures are cases where the image
output is RGB24, but the matching reference image is ARGB32 with
noticeable transparency. Some of the newly passing tests are cases
where the unused 'alpha' channel of an RGB24 image was not equal
to 0xff, and the previous code had incorrectly used this channel
in max_diff calculations.

1 files changed, 44 insertions, 68 deletions

diff --git a/.gitlab-ci/ignore-xlib-fallback-rgb24.txt b/.gitlab-ci/ignore-xlib-fallback-rgb24.txt
index f4effb215..617d4d07d 100644
--- a/.gitlab-ci/ignore-xlib-fallback-rgb24.txt
+++ b/.gitlab-ci/ignore-xlib-fallback-rgb24.txt
@@ -1,112 +1,88 @@
-arc-looping-dash
-bug-51910
+a1-clip-fill-rule
+alpha-similar
+big-empty-box
+big-empty-triangle
+big-little-box
+bitmap-font
+bug-361
+bug-431
 bug-seams
-caps
-caps-05
-caps-1
-caps-2
-caps-joins-05
-caps-joins-1
-caps-joins-2
-caps-joins-curve
-caps-sub-paths
-clear-source
-clip-disjoint-quad
-clip-image
-clip-mixed-antialias
-clip-polygons
-clip-push-group
+clip-device-offset
+clip-fill-rule-pixel-aligned
 clip-text
-close-path
-close-path-current-point
-copy-path
-coverage-abutting
-coverage-intersecting-quads
+clip-unbounded
 culled-glyphs
-dash-caps-joins
-dash-infinite-loop
-dash-scale
 dash-zero-length
-degenerate-curve-to
 degenerate-path
-degenerate-pen
-degenerate-rel-curve-to
+device-offset
+device-offset-positive
 extended-blend-alpha-mask
 fallback
+fill-and-stroke
+fill-empty
 fill-missed-stop
-filter-bilinear-extents
 finer-grained-fallbacks
-font-matrix-translation
+ft-color-font
 ft-show-glyphs-positioning
-ft-show-glyphs-table
 ft-text-vertical-layout-type1
 ft-text-vertical-layout-type3
-glyph-cache-pressure
+gradient-alpha
+gradient-constant-alpha
+gradient-zero-stops
+gradient-zero-stops-mask
 halo-transform
-infinite-join
-inverse-text
-joins
+image-surface-source
 large-twin-antialias-mixed
-leaky-dashed-stroke
-leaky-polygon
-line-width-scale
-line-width-tolerance
-long-dashed-lines
-mask-transformed-image
-mask-transformed-similar
+linear-gradient-one-stop
+mask-ctm
+mask-surface-ctm
 new-sub-path
-operator-alpha-alpha
+nil-surface
 over-above-source
 over-around-source
 over-between-source
+overlapping-boxes
 overlapping-glyphs
-partial-clip-text-bottom
-partial-clip-text-left
-partial-coverage-reference
-partial-coverage-three-quarter-reference
-path-stroke-twice
+pass-through
+pdf-surface-source
+pixman-downscale-best-24
+pixman-rotate
+ps-surface-source
 pthread-show-text
 pthread-similar
 push-group-color
 record1414x-select-font-face
 record1414x-text-transform
-recording-surface-extend-none
-recording-surface-over
-rectilinear-miter-limit
-reflected-stroke
+record-neg-extents-bounded
+record-neg-extents-unbounded
+record-replay-extend-none
+record-replay-extend-pad
+record-replay-extend-reflect
+record-replay-extend-repeat
 rel-path
-select-font-face
-self-copy
+scale-source-surface-paint
+set-source
 shifted-operator
 show-glyphs-advance
-show-text-current-point
 smask
-smask-image-mask
-smask-mask
-smask-paint
 smask-text
-smp-glyph
-stroke-ctm-caps
+source-surface-scale-paint
 subsurface
+subsurface-outside-target
 subsurface-scale
 surface-pattern-scale-down-extend-none
-surface-pattern-scale-up
-text-antialias-gray
 text-antialias-subpixel
 text-antialias-subpixel-bgr
 text-antialias-subpixel-rgb
 text-antialias-subpixel-vbgr
 text-antialias-subpixel-vrgb
-text-glyph-range
 text-pattern
 text-rotate
-text-transform
 text-unhinted-metrics
-transforms
-twin
+thin-lines
 twin-antialias-gray
 twin-antialias-mixed
 twin-antialias-none
 twin-antialias-subpixel
-unclosed-strokes
-xcomposite-projection
+xcb-surface-source
+xlib-surface-source