test: explicitly handle image formats in buffer_diff_core

In practice, the A and B images may be any mixture of RGB24 and
ARGB32 formats, so this change accepts all combinations of these
types, and converts the pixel values to a common (ARGB32) format
as needed.

Some of the newly added test failures are cases where the image
output is RGB24, but the matching reference image is ARGB32 with
noticeable transparency. Some of the newly passing tests are cases
where the unused 'alpha' channel of an RGB24 image was not equal
to 0xff, and the previous code had incorrectly used this channel
in max_diff calculations.

1 files changed, 34 insertions, 52 deletions

diff --git a/.gitlab-ci/ignore-xlib-rgb24.txt b/.gitlab-ci/ignore-xlib-rgb24.txt
index b7b11523b..cf2d7239d 100644
--- a/.gitlab-ci/ignore-xlib-rgb24.txt
+++ b/.gitlab-ci/ignore-xlib-rgb24.txt
@@ -1,22 +1,26 @@
+a1-clip-fill-rule
 aliasing
+alpha-similar
 arc-looping-dash
-bug-51910
+big-empty-box
+big-empty-triangle
+big-little-box
+bitmap-font
 bug-84115
 bug-extents
 bug-image-compositor
 bug-spline
-caps-joins-05
 caps-joins-curve
-caps-tails-curve
-clear-source
+clip-device-offset
 clip-disjoint
+clip-fill-rule-pixel-aligned
 clip-operator
 clip-shape
 clip-stroke
 clip-stroke-unbounded
 clip-text
+clip-unbounded
 close-path-current-point
-coverage-abutting
 coverage-column-triangles
 coverage-rhombus
 culled-glyphs
@@ -26,54 +30,50 @@ dash-scale
 degenerate-curve-to
 degenerate-pen
 degenerate-rel-curve-to
+device-offset
+device-offset-positive
 drunkard-tails
 extended-blend-alpha-mask
-extended-blend-mask
-fallback
 fill-and-stroke
 fill-and-stroke-alpha
 fill-and-stroke-alpha-add
+fill-empty
 fill-image
-filter-bilinear-extents
-font-matrix-translation
+ft-color-font
 ft-show-glyphs-positioning
-ft-show-glyphs-table
 ft-text-vertical-layout-type1
 ft-text-vertical-layout-type3
-glyph-cache-pressure
+gradient-alpha
+gradient-constant-alpha
+gradient-zero-stops
+gradient-zero-stops-mask
 halo
 halo-transform
 hatchings
-infinite-join
-inverse-text
+image-surface-source
 joins
 joins-loop
 joins-retrace
-joins-star
-large-font
 large-twin-antialias-mixed
 leaky-dashed-stroke
-linear-gradient
-linear-gradient-subset
+linear-gradient-one-stop
 line-width-scale
 line-width-tolerance
 long-dashed-lines
-mask
-mask-transformed-image
-mask-transformed-similar
-miter-precision
+mask-ctm
+mask-surface-ctm
 new-sub-path
-operator-alpha-alpha
-operator-clear
+nil-surface
 operator-source
 overlapping-boxes
 overlapping-dash-caps
 overlapping-glyphs
-partial-clip-text-bottom
-partial-clip-text-left
-partial-coverage-reference
-partial-coverage-three-quarter-reference
+pass-through
 path-stroke-twice
+pdf-surface-source
+pixman-downscale-best-24
+pixman-rotate
+ps-surface-source
 pthread-show-text
 radial-gradient
 radial-gradient-mask
@@ -93,13 +93,11 @@ record2x-fill-alpha
 record2x-paint-alpha-clip-mask
 record2x-select-font-face
 record2x-text-transform
-record90-fill-alpha
 record90-paint-alpha-clip
 record90-paint-alpha-solid-clip
 record90-select-font-face
 record90-self-intersecting
 record90-text-transform
-recordflip-fill-alpha
 recordflip-paint-alpha-clip-mask
 recordflip-select-font-face
 recordflip-self-intersecting
@@ -109,12 +107,7 @@ recordflip-whole-paint-alpha-clip-mask
 recordflip-whole-select-font-face
 recordflip-whole-self-intersecting
 recordflip-whole-text-transform
-recording-surface-extend-none
 recording-surface-extend-pad
-recording-surface-extend-reflect
-recording-surface-extend-repeat
-recording-surface-over
-recording-surface-source
 record-neg-extents-bounded
 record-neg-extents-unbounded
 record-replay-extend-none
@@ -126,57 +119,46 @@ record-self-intersecting
 record-text-transform
 reflected-stroke
 rel-path
-rotated-clip
 rounded-rectangle-stroke
 scale-offset-image
 scale-offset-similar
-select-font-face
+scale-source-surface-paint
+set-source
 shape-general-convex
 shape-sierpinski
 shifted-operator
 show-glyphs-advance
-show-text-current-point
 simple-edge
 smask
-smask-fill
-smask-image-mask
-smask-mask
-smask-paint
 smask-stroke
 smask-text
-smp-glyph
+source-surface-scale-paint
 spline-decomposition
 stroke-clipped
-stroke-ctm-caps
 stroke-image
 stroke-pattern
 subsurface
+subsurface-outside-target
 subsurface-scale
-surface-pattern-operator
-surface-pattern-scale-up
-text-antialias-gray
 text-antialias-subpixel
 text-antialias-subpixel-bgr
 text-antialias-subpixel-rgb
 text-antialias-subpixel-vbgr
 text-antialias-subpixel-vrgb
-text-glyph-range
 text-pattern
 text-rotate
-text-transform
 text-unhinted-metrics
+thin-lines
 tighten-bounds
-trap-clip
 twin
 twin-antialias-gray
 twin-antialias-mixed
 twin-antialias-none
 twin-antialias-subpixel
-unbounded-operator
 unclosed-strokes
 user-font
 user-font-proxy
 world-map
-world-map-fill
 world-map-stroke
-xcomposite-projection
+xcb-surface-source
+xlib-surface-source