[cairo-error] Clean up all the warnings and missing _cairo_error() calls.

Every time we assign or return a hard-coded error status wrap that value
with a call to _cairo_error(). So the idiom becomes:
    status = _cairo_error (CAIRO_STATUS_NO_MEMORY);
or
    return _cairo_error (CAIRO_STATUS_INVALID_DASH);

This ensures that a breakpoint placed on _cairo_error() will trigger
immediately cairo detects the error.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/cairo-font-options.c b/src/cairo-font-options.c
index b3a5660c3..c5d5c12b5 100644
--- a/src/cairo-font-options.c
+++ b/src/cairo-font-options.c
@@ -90,7 +90,7 @@ cairo_font_options_create (void)
 
     options = malloc (sizeof (cairo_font_options_t));
     if (!options) {
-	_cairo_error (CAIRO_STATUS_NO_MEMORY);
+	_cairo_error_throw (CAIRO_STATUS_NO_MEMORY);
 	return (cairo_font_options_t *)&_cairo_font_options_nil;
     }
 
@@ -123,7 +123,7 @@ cairo_font_options_copy (const cairo_font_options_t *original)
 
     options = malloc (sizeof (cairo_font_options_t));
     if (!options) {
-	_cairo_error (CAIRO_STATUS_NO_MEMORY);
+	_cairo_error_throw (CAIRO_STATUS_NO_MEMORY);
 	return (cairo_font_options_t *)&_cairo_font_options_nil;
     }