diff options
| author | John Lindgren <john.lindgren@aol.com> | 2015-05-31 11:48:30 -0400 |
|---|---|---|
| committer | Bryce Harrington <bryce@osg.samsung.com> | 2015-06-26 16:12:33 -0700 |
| commit | bb24f165ff57973347b34956a371c6b33d2d9b59 (patch) | |
| tree | 5bc7ee459a6277bbae9d48e49b1a4665175d3027 /src/cairo-freelist.c | |
| parent | 1bcce4362927952b25cb916f862dde6fd35f8125 (diff) | |
| download | cairo-bb24f165ff57973347b34956a371c6b33d2d9b59.tar.gz | |
Avoid indiscriminate use of VALGRIND_MAKE_MEM_NOACCESS.
Marking stack-allocated objects as no-access creates false positives,
which distract from finding real memory errors.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=52548
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>
Diffstat (limited to 'src/cairo-freelist.c')
| -rw-r--r-- | src/cairo-freelist.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/cairo-freelist.c b/src/cairo-freelist.c index d596eab81..631fe48d5 100644 --- a/src/cairo-freelist.c +++ b/src/cairo-freelist.c @@ -80,7 +80,7 @@ _cairo_freelist_free (cairo_freelist_t *freelist, void *voidnode) if (node) { node->next = freelist->first_free_node; freelist->first_free_node = node; - VG (VALGRIND_MAKE_MEM_NOACCESS (node, freelist->nodesize)); + VG (VALGRIND_MAKE_MEM_UNDEFINED (node, freelist->nodesize)); } } @@ -97,7 +97,7 @@ _cairo_freepool_init (cairo_freepool_t *freepool, unsigned nodesize) freepool->embedded_pool.rem = sizeof (freepool->embedded_data); freepool->embedded_pool.data = freepool->embedded_data; - VG (VALGRIND_MAKE_MEM_NOACCESS (freepool->embedded_data, sizeof (freepool->embedded_data))); + VG (VALGRIND_MAKE_MEM_UNDEFINED (freepool->embedded_data, sizeof (freepool->embedded_data))); } void @@ -119,7 +119,7 @@ _cairo_freepool_fini (cairo_freepool_t *freepool) pool = next; } - VG (VALGRIND_MAKE_MEM_NOACCESS (freepool, sizeof (freepool))); + VG (VALGRIND_MAKE_MEM_UNDEFINED (freepool, sizeof (freepool))); } void * @@ -152,7 +152,7 @@ _cairo_freepool_alloc_from_new_pool (cairo_freepool_t *freepool) pool->rem = poolsize - freepool->nodesize; pool->data = (uint8_t *) (pool + 1) + freepool->nodesize; - VG (VALGRIND_MAKE_MEM_NOACCESS (pool->data, pool->rem)); + VG (VALGRIND_MAKE_MEM_UNDEFINED (pool->data, pool->rem)); return pool + 1; } |