[cairo-error] Clean up all the warnings and missing _cairo_error() calls.

Every time we assign or return a hard-coded error status wrap that value
with a call to _cairo_error(). So the idiom becomes:
    status = _cairo_error (CAIRO_STATUS_NO_MEMORY);
or
    return _cairo_error (CAIRO_STATUS_INVALID_DASH);

This ensures that a breakpoint placed on _cairo_error() will trigger
immediately cairo detects the error.

1 files changed, 2 insertions, 4 deletions

diff --git a/src/cairo-lzw.c b/src/cairo-lzw.c
index 73d82a3e0..6158eaf40 100644
--- a/src/cairo-lzw.c
+++ b/src/cairo-lzw.c
@@ -75,8 +75,7 @@ _lzw_buf_init (lzw_buf_t *buf, int size)
     buf->data = malloc (size);
     if (buf->data == NULL) {
 	buf->data_size = 0;
-	buf->status = CAIRO_STATUS_NO_MEMORY;
-	_cairo_error (CAIRO_STATUS_NO_MEMORY);
+	buf->status = _cairo_error (CAIRO_STATUS_NO_MEMORY);
 	return;
     }
 }
@@ -102,8 +101,7 @@ _lzw_buf_grow (lzw_buf_t *buf)
     if (new_data == NULL) {
 	free (buf->data);
 	buf->data_size = 0;
-	buf->status = CAIRO_STATUS_NO_MEMORY;
-	_cairo_error (CAIRO_STATUS_NO_MEMORY);
+	buf->status = _cairo_error (CAIRO_STATUS_NO_MEMORY);
 	return buf->status;
     }