Remove clip handling from generic surface layer.

Handling clip as part of the surface state, as opposed to being part of
the operation state, is cumbersome and a hindrance to providing true proxy
surface support. For example, the clip must be copied from the surface
onto the fallback image, but this was forgotten causing undue hassle in
each backend. Another example is the contortion the meta surface
endures to ensure the clip is correctly recorded. By contrast passing the
clip along with the operation is quite simple and enables us to write
generic handlers for providing surface wrappers. (And in the future, we
should be able to write more esoteric wrappers, e.g. automatic 2x FSAA,
trivially.)

In brief, instead of the surface automatically applying the clip before
calling the backend, the backend can call into a generic helper to apply
clipping. For raster surfaces, clip regions are handled automatically as
part of the composite interface. For vector surfaces, a clip helper is
introduced to replay and callback into an intersect_clip_path() function
as necessary.

Whilst this is not primarily a performance related change (the change
should just move the computation of the clip from the moment it is applied
by the user to the moment it is required by the backend), it is important
to track any potential regression:

ppc:
Speedups
========
image-rgba         evolution-20090607-0    1026085.22 0.18% -> 672972.07 0.77%:  1.52x speedup
▌
image-rgba         evolution-20090618-0    680579.98 0.12% -> 573237.66  0.16%:  1.19x speedup
▎
image-rgba      swfdec-fill-rate-4xaa-0    460296.92 0.36% -> 407464.63  0.42%:  1.13x speedup
▏
image-rgba      swfdec-fill-rate-2xaa-0    128431.95 0.47% -> 115051.86  0.42%:  1.12x speedup
▏
Slowdowns
=========
image-rgba     firefox-periodic-table-0    56837.61 0.78% -> 66055.17    3.20%:  1.09x slowdown
▏

1 files changed, 8 insertions, 3 deletions

diff --git a/src/cairo-path-fill.c b/src/cairo-path-fill.c
index 9569c9e90..123da96e2 100644
--- a/src/cairo-path-fill.c
+++ b/src/cairo-path-fill.c
@@ -125,12 +125,12 @@ _cairo_filler_close_path (void *closure)
 }
 
 static cairo_int_status_t
-_cairo_path_fixed_fill_rectangle (cairo_path_fixed_t	*path,
+_cairo_path_fixed_fill_rectangle (const cairo_path_fixed_t	*path,
 				  cairo_fill_rule_t	 fill_rule,
 				  cairo_traps_t		*traps);
 
 cairo_status_t
-_cairo_path_fixed_fill_to_traps (cairo_path_fixed_t *path,
+_cairo_path_fixed_fill_to_traps (const cairo_path_fixed_t *path,
 				 cairo_fill_rule_t   fill_rule,
 				 double              tolerance,
 				 cairo_traps_t      *traps)
@@ -138,6 +138,8 @@ _cairo_path_fixed_fill_to_traps (cairo_path_fixed_t *path,
     cairo_status_t status = CAIRO_STATUS_SUCCESS;
     cairo_filler_t filler;
 
+    traps->maybe_region = path->maybe_fill_region;
+
     /* Before we do anything else, we use a special-case filler for
      * a device-axis aligned rectangle if possible. */
     status = _cairo_path_fixed_fill_rectangle (path, fill_rule, traps);
@@ -181,12 +183,15 @@ BAIL:
  * this function will return %CAIRO_INT_STATUS_UNSUPPORTED.
  */
 static cairo_int_status_t
-_cairo_path_fixed_fill_rectangle (cairo_path_fixed_t	*path,
+_cairo_path_fixed_fill_rectangle (const cairo_path_fixed_t	*path,
 				  cairo_fill_rule_t	 fill_rule,
 				  cairo_traps_t		*traps)
 {
     cairo_box_t box;
 
+    if (! path->is_rectilinear)
+	return CAIRO_INT_STATUS_UNSUPPORTED;
+
     if (_cairo_path_fixed_is_box (path, &box)) {
 	if (box.p1.x > box.p2.x) {
 	    cairo_fixed_t t;