[cairo-error] Clean up all the warnings and missing _cairo_error() calls.

Every time we assign or return a hard-coded error status wrap that value
with a call to _cairo_error(). So the idiom becomes:
    status = _cairo_error (CAIRO_STATUS_NO_MEMORY);
or
    return _cairo_error (CAIRO_STATUS_INVALID_DASH);

This ensures that a breakpoint placed on _cairo_error() will trigger
immediately cairo detects the error.

1 files changed, 2 insertions, 4 deletions

diff --git a/src/test-paginated-surface.c b/src/test-paginated-surface.c
index 1e08c2d86..3e9bad8c7 100644
--- a/src/test-paginated-surface.c
+++ b/src/test-paginated-surface.c
@@ -75,14 +75,12 @@ _cairo_test_paginated_surface_create_for_data (unsigned char		*data,
 								width, height,
 								stride);
     status = cairo_surface_status (target);
-    if (status) {
-	_cairo_error (status);
+    if (status)
 	return (cairo_surface_t *) &_cairo_surface_nil;
-    }
 
     surface = malloc (sizeof (test_paginated_surface_t));
     if (surface == NULL) {
-	_cairo_error (CAIRO_STATUS_NO_MEMORY);
+	_cairo_error_throw (CAIRO_STATUS_NO_MEMORY);
 	return (cairo_surface_t *) &_cairo_surface_nil;
     }