diff options
author | Carl Worth <cworth@cworth.org> | 2008-09-25 02:49:44 -0700 |
---|---|---|
committer | Carl Worth <cworth@cworth.org> | 2008-09-25 02:49:44 -0700 |
commit | a172d87b4cbcc0bda9c376ab5c5cfdea2e20db63 (patch) | |
tree | fac497e8549e56bd2f0ac0a3a05cce12f56e1c30 /test/device-offset-scale.c | |
parent | 36eef09b583077a899e446d5f28b5cc15335cf5f (diff) | |
download | cairo-a172d87b4cbcc0bda9c376ab5c5cfdea2e20db63.tar.gz |
Make device-offset-scale an XFAIL test due to SVG failure.
It's sad to have to do this. Back with commit 1a9809baa was the
original fix for device-offset-scale, (right after the test was
added), and it fixed it for all backends, including SVG. The fix
involved combining device_transform and CTM into the pattern matrix.
But then, we added the mask-transformed-image and
mask-transformed-similar tests, and commit 20be3182ef29 for fixing an
SVG-specific bug with masks. That fix involved subtracting away the
pattern matrix when emitting a mask to adhere to SVG semantics.
Unfortunately, this change also made the device-offset-scale test
start failing. A correct fix would probably subtract away only the CTM
portion and not the devive_transform. However, the
_cairo_svg_surface_mask function sees only a pattern matrix and
doesn't know how to separate it into CTM and device_transform pieces.
So fixing this will probably require a change to the surface-backend
interface. And since we're not willing to do that so close to a major
release, we're adding yet another XFAIL.
Diffstat (limited to 'test/device-offset-scale.c')
-rw-r--r-- | test/device-offset-scale.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/device-offset-scale.c b/test/device-offset-scale.c index 1c2537d62..eabe15a76 100644 --- a/test/device-offset-scale.c +++ b/test/device-offset-scale.c @@ -32,7 +32,8 @@ static cairo_test_draw_function_t draw; static const cairo_test_t test = { "device-offset-scale", - "Test that the device-offset transform is transformed by the ctm.", + "Test that the device-offset transform is transformed by the ctm." + "\nCurrently fails with the SVG backend.", WIDTH, HEIGHT, draw }; |