summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYan, Zheng <zheng.z.yan@intel.com>2013-10-21 09:06:16 +0800
committerYan, Zheng <zheng.z.yan@intel.com>2013-10-21 09:06:16 +0800
commit9fa357d37b4460f560c9f16640e62f372464a9aa (patch)
tree31258ebaaaffe01f68514547eca7325430e93d38
parent1f02d006b7de828299b1e4e9ad530d88a3b9781c (diff)
downloadceph-wip-backtrace.tar.gz
mds: update backtrace when old format inode is touchedwip-backtrace
We updated inode format version to 7 when introducing inode backtrace. If we found a inode's format version < 7 when fetching the inode, set the inode's backtrace_version to 0, to indicate the inode's backtrace is out of data. When touching a inode with backtrace_version == 0, we also update its backtrace. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
-rw-r--r--src/mds/Locker.cc4
-rw-r--r--src/mds/Server.cc5
-rw-r--r--src/mds/mdstypes.cc2
3 files changed, 11 insertions, 0 deletions
diff --git a/src/mds/Locker.cc b/src/mds/Locker.cc
index 7f852519714..e11bbd8fe9a 100644
--- a/src/mds/Locker.cc
+++ b/src/mds/Locker.cc
@@ -2900,6 +2900,10 @@ bool Locker::_do_cap_update(CInode *in, Capability *cap,
wrlock_force(&in->xattrlock, mut);
}
+
+ // update backtrace for old format inode. (see inode_t::decode)
+ if (pi->backtrace_version == 0)
+ pi->update_backtrace();
mut->auth_pin(in);
mdcache->predirty_journal_parents(mut, &le->metablob, in, 0, PREDIRTY_PRIMARY, 0, follows);
diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index 0c500cdfe63..de0916a644b 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -3206,6 +3206,11 @@ void Server::handle_client_setattr(MDRequest *mdr)
// log + wait
le->metablob.add_client_req(req->get_reqid(), req->get_oldest_client_tid());
+
+ // update backtrace for old format inode. (see inode_t::decode)
+ if (pi->backtrace_version == 0)
+ pi->update_backtrace();
+
mdcache->predirty_journal_parents(mdr, &le->metablob, cur, 0, PREDIRTY_PRIMARY, false);
mdcache->journal_dirty_inode(mdr, &le->metablob, cur);
diff --git a/src/mds/mdstypes.cc b/src/mds/mdstypes.cc
index 362f74774c4..df6cd8efa9f 100644
--- a/src/mds/mdstypes.cc
+++ b/src/mds/mdstypes.cc
@@ -295,6 +295,8 @@ void inode_t::decode(bufferlist::iterator &p)
::decode(backtrace_version, p);
if (struct_v >= 7)
::decode(old_pools, p);
+ else
+ backtrace_version = 0; // note inode which has no backtrace
if (struct_v >= 8)
::decode(max_size_ever, p);