diff options
| author | Alberto Contreras <alberto.contreras@canonical.com> | 2023-03-14 10:36:36 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-14 10:36:36 +0100 |
| commit | 8a0feb1ec04b211f9444e0eeaf473b670db475bd (patch) | |
| tree | fd7d1a596b5dcd8a9a5b9077004459735218a263 /cloudinit/sources | |
| parent | 2e697bb0e7f251385e9c227629b78d59e4cfea8b (diff) | |
| download | cloud-init-git-8a0feb1ec04b211f9444e0eeaf473b670db475bd.tar.gz | |
chore: fix style tip (#2071)
- remove too broad exceptions
- ignore dynamic base types in templater
Diffstat (limited to 'cloudinit/sources')
| -rw-r--r-- | cloudinit/sources/DataSourceDigitalOcean.py | 2 | ||||
| -rw-r--r-- | cloudinit/sources/DataSourceHetzner.py | 2 | ||||
| -rw-r--r-- | cloudinit/sources/DataSourceNWCS.py | 4 | ||||
| -rw-r--r-- | cloudinit/sources/DataSourceUpCloud.py | 4 | ||||
| -rw-r--r-- | cloudinit/sources/helpers/vmware/imc/config_nic.py | 2 |
5 files changed, 8 insertions, 6 deletions
diff --git a/cloudinit/sources/DataSourceDigitalOcean.py b/cloudinit/sources/DataSourceDigitalOcean.py index 52d3ad26..b6a110aa 100644 --- a/cloudinit/sources/DataSourceDigitalOcean.py +++ b/cloudinit/sources/DataSourceDigitalOcean.py @@ -102,7 +102,7 @@ class DataSourceDigitalOcean(sources.DataSource): interfaces = self.metadata.get("interfaces") LOG.debug(interfaces) if not interfaces: - raise Exception("Unable to get meta-data from server....") + raise RuntimeError("Unable to get meta-data from server....") nameservers = self.metadata_full["dns"]["nameservers"] self._network_config = do_helper.convert_network_configuration( diff --git a/cloudinit/sources/DataSourceHetzner.py b/cloudinit/sources/DataSourceHetzner.py index 90531769..14f14677 100644 --- a/cloudinit/sources/DataSourceHetzner.py +++ b/cloudinit/sources/DataSourceHetzner.py @@ -129,7 +129,7 @@ class DataSourceHetzner(sources.DataSource): _net_config = self.metadata["network-config"] if not _net_config: - raise Exception("Unable to get meta-data from server....") + raise RuntimeError("Unable to get meta-data from server....") self._network_config = _net_config diff --git a/cloudinit/sources/DataSourceNWCS.py b/cloudinit/sources/DataSourceNWCS.py index e21383d2..3a483049 100644 --- a/cloudinit/sources/DataSourceNWCS.py +++ b/cloudinit/sources/DataSourceNWCS.py @@ -55,7 +55,7 @@ class DataSourceNWCS(sources.DataSource): md = self.get_metadata() if md is None: - raise Exception("failed to get metadata") + raise RuntimeError("failed to get metadata") self.metadata_full = md @@ -111,7 +111,7 @@ class DataSourceNWCS(sources.DataSource): return self._network_config if not self.metadata["network"]["config"]: - raise Exception("Unable to get metadata from server") + raise RuntimeError("Unable to get metadata from server") # metadata sends interface names, but we dont want to use them for i in self.metadata["network"]["config"]: diff --git a/cloudinit/sources/DataSourceUpCloud.py b/cloudinit/sources/DataSourceUpCloud.py index d6b74bc1..43122f0b 100644 --- a/cloudinit/sources/DataSourceUpCloud.py +++ b/cloudinit/sources/DataSourceUpCloud.py @@ -126,7 +126,9 @@ class DataSourceUpCloud(sources.DataSource): raw_network_config = self.metadata.get("network") if not raw_network_config: - raise Exception("Unable to get network meta-data from server....") + raise RuntimeError( + "Unable to get network meta-data from server...." + ) self._network_config = uc_helper.convert_network_config( raw_network_config, diff --git a/cloudinit/sources/helpers/vmware/imc/config_nic.py b/cloudinit/sources/helpers/vmware/imc/config_nic.py index 5ac8cbf1..ba2488be 100644 --- a/cloudinit/sources/helpers/vmware/imc/config_nic.py +++ b/cloudinit/sources/helpers/vmware/imc/config_nic.py @@ -62,7 +62,7 @@ class NicConfigurator: if not primary_nics: return None elif len(primary_nics) > 1: - raise Exception( + raise RuntimeError( "There can only be one primary nic", [nic.mac for nic in primary_nics], ) |