summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorScott Moser <smoser@ubuntu.com>2016-06-21 10:00:24 -0400
committerScott Moser <smoser@ubuntu.com>2016-06-21 10:00:24 -0400
commit403a6045a84a9c9435f822dd7cc1baef33ad40ab (patch)
tree89284322ddf190adcd3f44eacadb08879764e3c9
parent30178e219cce007505d42b49ceb7499364b435de (diff)
downloadcloud-init-403a6045a84a9c9435f822dd7cc1baef33ad40ab.tar.gz
make _render_iface return a list of sections rather than one section
-rw-r--r--cloudinit/net/eni.py19
1 files changed, 11 insertions, 8 deletions
diff --git a/cloudinit/net/eni.py b/cloudinit/net/eni.py
index 5a91fcf2..b93c8616 100644
--- a/cloudinit/net/eni.py
+++ b/cloudinit/net/eni.py
@@ -353,10 +353,11 @@ class Renderer(renderer.Renderer):
return content
def _render_iface(self, iface):
- lines = []
+ sections = []
subnets = iface.get('subnets', {})
if subnets:
for index, subnet in zip(range(0, len(subnets)), subnets):
+ lines = []
iface['index'] = index
iface['mode'] = subnet['type']
iface['control'] = subnet.get('control', 'auto')
@@ -370,14 +371,17 @@ class Renderer(renderer.Renderer):
lines.extend(_iface_start_entry(iface, index))
lines.extend(_iface_add_subnet(iface, subnet))
lines.extend(_iface_add_attrs(iface))
- lines.append("")
+
+ sections.append(lines)
else:
# ifenslave docs say to auto the slave devices
+ lines = []
if 'bond-master' in iface:
lines.append("auto {name}".format(**iface))
lines.append("iface {name} {inet} {mode}".format(**iface))
lines.extend(_iface_add_attrs(iface))
- return lines
+ sections.append(lines)
+ return sections
def _render_interfaces(self, network_state):
'''Given state, emit etc/network/interfaces content.'''
@@ -411,20 +415,19 @@ class Renderer(renderer.Renderer):
'vlan': 3,
}
- sections = [self._render_iface(lo)]
+ sections = []
+ sections.extend(self._render_iface(lo))
for iface in sorted(network_state.iter_interfaces(),
key=lambda k: (order[k['type']], k['name'])):
if iface.get('name') == "lo":
continue
- sections.append(self._render_iface(iface))
+ sections.extend(self._render_iface(iface))
for route in network_state.iter_routes():
sections.append(self._render_route(route))
- # global replacements until v2 format
- content = ''.join(['\n'.join(s) + '\n\n' for s in sections])
- return content
+ return '\n\n'.join(['\n'.join(s) for s in sections])
def render_network_state(self, target, network_state):
fpeni = os.path.join(target, self.eni_path)