diff options
| author | Craig Scott <craig.scott@crascit.com> | 2021-02-21 17:40:21 +1100 |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2021-02-22 11:02:20 -0500 |
| commit | 404cddb7bbb0e05bba2f3023f0ee2fa302c35124 (patch) | |
| tree | 5b8d4697fcd6982687dc3965cc63ffc0dfbd608e /Modules/ExternalProject | |
| parent | eefcf2e0a6ed07fd288314d91eaa4a96d9da6ec8 (diff) | |
| download | cmake-404cddb7bbb0e05bba2f3023f0ee2fa302c35124.tar.gz | |
ExternalProject: Fix misuse of IS_NEWER_THAN in timestamp checks
When using a file system which only has second resolution timestamps,
there is a reasonably high likelihood of timestamps being the same.
The IS_NEWER_THAN test returns true when timestamps are the same,
so don't redo downloads when they match exactly.
Diffstat (limited to 'Modules/ExternalProject')
| -rw-r--r-- | Modules/ExternalProject/gitclone.cmake.in | 3 | ||||
| -rw-r--r-- | Modules/ExternalProject/hgclone.cmake.in | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/Modules/ExternalProject/gitclone.cmake.in b/Modules/ExternalProject/gitclone.cmake.in index a2e900c112..edbdd72bde 100644 --- a/Modules/ExternalProject/gitclone.cmake.in +++ b/Modules/ExternalProject/gitclone.cmake.in @@ -7,7 +7,8 @@ set(quiet "@quiet@") set(script_dir "@CMAKE_CURRENT_FUNCTION_LIST_DIR@/ExternalProject") include(${script_dir}/captured_process_setup.cmake) -if(NOT "@gitclone_infofile@" IS_NEWER_THAN "@gitclone_stampfile@") +if(EXISTS "@gitclone_stampfile@" AND EXISTS "@gitclone_infofile@" AND + "@gitclone_stampfile@" IS_NEWER_THAN "@gitclone_infofile@") if(NOT quiet) message(STATUS "Avoiding repeated git clone, stamp file is up to date: " diff --git a/Modules/ExternalProject/hgclone.cmake.in b/Modules/ExternalProject/hgclone.cmake.in index 5561955cad..9a574d201c 100644 --- a/Modules/ExternalProject/hgclone.cmake.in +++ b/Modules/ExternalProject/hgclone.cmake.in @@ -7,7 +7,8 @@ set(quiet "@quiet@") set(script_dir "@CMAKE_CURRENT_FUNCTION_LIST_DIR@/ExternalProject") include(${script_dir}/captured_process_setup.cmake) -if(NOT "@hgclone_infofile@" IS_NEWER_THAN "@hgclone_stampfile@") +if(EXISTS "@hgclone_stampfile@" AND EXISTS "@hgclone_infofile@" AND + "@hgclone_stampfile@" IS_NEWER_THAN "@hgclone_infofile@") if(NOT quiet) message(STATUS "Avoiding repeated hg clone, stamp file is up to date: " |