diff options
| author | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-05-26 21:58:51 +0200 |
|---|---|---|
| committer | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-05-26 21:58:51 +0200 |
| commit | 618fb23fc9838d344e2033c64bfc1a3a55bb7f61 (patch) | |
| tree | abaabfaae8a9f5448d7ee062c757c61254792995 /Source/CPack/cmCPackDebGenerator.h | |
| parent | acd8a73044e879286f0cfa24b54497a8307f204b (diff) | |
| download | cmake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.tar.gz | |
Pass arguments that are not modified as const&.
Use clang-tidy's performance-unnecessary-value-param checker to find
value parameter declarations of expensive to copy types that are not
modified inside the function. Ignore findings in kwsys.
After applying the fix-its, manually change `const T&` to `T const&`.
Diffstat (limited to 'Source/CPack/cmCPackDebGenerator.h')
| -rw-r--r-- | Source/CPack/cmCPackDebGenerator.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Source/CPack/cmCPackDebGenerator.h b/Source/CPack/cmCPackDebGenerator.h index f640ab4a66..ff34ca5719 100644 --- a/Source/CPack/cmCPackDebGenerator.h +++ b/Source/CPack/cmCPackDebGenerator.h @@ -49,7 +49,8 @@ protected: /** * This method factors out the work done in component packaging case. */ - int PackageOnePack(std::string initialToplevel, std::string packageName); + int PackageOnePack(std::string const& initialToplevel, + std::string const& packageName); /** * The method used to package files when component * install is used. This will create one |