diff options
| author | Ben Boeckel <ben.boeckel@kitware.com> | 2018-10-29 15:49:44 -0400 |
|---|---|---|
| committer | Ben Boeckel <ben.boeckel@kitware.com> | 2018-11-02 10:25:56 -0400 |
| commit | 85aceda0262bff58a0126b2d4e75756e0507fe3c (patch) | |
| tree | fe919665f22ef165e10e87220b313de593cb0f21 /Source/cmNinjaNormalTargetGenerator.cxx | |
| parent | d697f4eb489ee42a08f2a15efffe55e1c29860b7 (diff) | |
| download | cmake-85aceda0262bff58a0126b2d4e75756e0507fe3c.tar.gz | |
cmNinjaNormalTargetGenerator: don't use `|| true` for link-what-you-use
With the `|| true`, a linker error before running link-what-you-use
would also use the `|| true` fragment and unconditionally succeed. Just
skip the addition since `--lwyu=` ignores the return value anyways.
Fixes #18524
Diffstat (limited to 'Source/cmNinjaNormalTargetGenerator.cxx')
| -rw-r--r-- | Source/cmNinjaNormalTargetGenerator.cxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/Source/cmNinjaNormalTargetGenerator.cxx b/Source/cmNinjaNormalTargetGenerator.cxx index 64369698ea..1386706b6f 100644 --- a/Source/cmNinjaNormalTargetGenerator.cxx +++ b/Source/cmNinjaNormalTargetGenerator.cxx @@ -506,7 +506,6 @@ std::vector<std::string> cmNinjaNormalTargetGenerator::ComputeLinkCmd() gt.GetFullPath(cfgName, cmStateEnums::RuntimeBinaryArtifact, /*realname=*/true)); cmakeCommand += targetOutputReal; - cmakeCommand += " || true"; linkCmds.push_back(std::move(cmakeCommand)); } return linkCmds; |