clang-format: Explicitly require version 3.8 of the tool

Versions of clang-format newer than 3.8 produce different output.
Our source code guide says that version 3.8 exactly must be used.
Update the comment in our `.clang-format` config file accordingly.
Add a check to our formatting script to verify the version.
Also update its tool search to look for the explicitly-named
3.8 variant first.

1 files changed, 6 insertions, 1 deletions

diff --git a/Utilities/Scripts/clang-format.bash b/Utilities/Scripts/clang-format.bash
index 3b331a18f4..4c6225dfa8 100755
--- a/Utilities/Scripts/clang-format.bash
+++ b/Utilities/Scripts/clang-format.bash
@@ -78,8 +78,8 @@ test "$#" = 0 || die "$usage"
 
 # Find a default tool.
 tools='
-  clang-format
   clang-format-3.8
+  clang-format
 '
 if test "x$clang_format" = "x"; then
     for tool in $tools; do
@@ -96,6 +96,11 @@ if ! type -p "$clang_format" >/dev/null; then
     exit 1
 fi
 
+if ! "$clang_format" --version | grep 'clang-format version 3\.8' >/dev/null 2>/dev/null; then
+    echo "clang-format version 3.8 is required (exactly)"
+    exit 1
+fi
+
 # Select listing mode.
 case "$mode" in
     '')       echo "$usage"; exit 0 ;;