diff options
author | Jordan Rupprecht <rupprecht@google.com> | 2018-09-27 18:13:01 +0000 |
---|---|---|
committer | Jordan Rupprecht <rupprecht@google.com> | 2018-09-27 18:13:01 +0000 |
commit | a9ffcafe1ed0672cf13db1ee8aa166ee43bff513 (patch) | |
tree | abb576841e5fcba0f43d141b0000388bd8ed4205 | |
parent | bf2aafb66fad514a4a5839ff3a6aff68d9dfda8c (diff) | |
download | compiler-rt-a9ffcafe1ed0672cf13db1ee8aa166ee43bff513.tar.gz |
[compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on Windows.
Summary:
-lm is needed for these tests on Linux, but the lit config for this package automatically adds it for Linux and excludes it for Windows. So we should be able to get these tests running again by just dropping -lm and let the lit config add it when possible.
I was under the impression that -lm worked across platforms because it exists in other tests without and 'UNSUPPORTED: windows' commands (e.g. divsc3_test.c), but those are actually excluded because they 'REQUIRES: c99-complex' which is excluded from windows platforms (also by the local lit config).
I don't have easy access to a windows machine to verify this patch, but I can trigger a build bot run on clang-x64-ninja-win7 shortly after submitting.
Reviewers: hans
Subscribers: dberris, delcypher, llvm-commits, #sanitizers
Differential Revision: https://reviews.llvm.org/D52563
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@343245 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | test/builtins/Unit/compiler_rt_logb_test.c | 4 | ||||
-rw-r--r-- | test/builtins/Unit/compiler_rt_logbf_test.c | 4 | ||||
-rw-r--r-- | test/builtins/Unit/compiler_rt_logbl_test.c | 4 |
3 files changed, 3 insertions, 9 deletions
diff --git a/test/builtins/Unit/compiler_rt_logb_test.c b/test/builtins/Unit/compiler_rt_logb_test.c index 5cc4c864d..796765980 100644 --- a/test/builtins/Unit/compiler_rt_logb_test.c +++ b/test/builtins/Unit/compiler_rt_logb_test.c @@ -1,6 +1,4 @@ -// Linking with -lm won't work on Windows. -// UNSUPPORTED: windows -// RUN: %clang_builtins %s %librt -lm -o %t && %run %t +// RUN: %clang_builtins %s %librt -o %t && %run %t //===-- compiler_rt_logb_test.c - Test __compiler_rt_logb -----------------===// // // The LLVM Compiler Infrastructure diff --git a/test/builtins/Unit/compiler_rt_logbf_test.c b/test/builtins/Unit/compiler_rt_logbf_test.c index 350f47c1b..5a4979a4b 100644 --- a/test/builtins/Unit/compiler_rt_logbf_test.c +++ b/test/builtins/Unit/compiler_rt_logbf_test.c @@ -1,6 +1,4 @@ -// Linking with -lm won't work on Windows. -// UNSUPPORTED: windows -// RUN: %clang_builtins %s %librt -lm -o %t && %run %t +// RUN: %clang_builtins %s %librt -o %t && %run %t //===-- compiler_rt_logbf_test.c - Test __compiler_rt_logbf ---------------===// // // The LLVM Compiler Infrastructure diff --git a/test/builtins/Unit/compiler_rt_logbl_test.c b/test/builtins/Unit/compiler_rt_logbl_test.c index f29c0f0f1..2617748e9 100644 --- a/test/builtins/Unit/compiler_rt_logbl_test.c +++ b/test/builtins/Unit/compiler_rt_logbl_test.c @@ -1,6 +1,4 @@ -// Linking with -lm won't work on Windows. -// UNSUPPORTED: windows -// RUN: %clang_builtins %s %librt -lm -o %t && %run %t +// RUN: %clang_builtins %s %librt -o %t && %run %t //===-- compiler_rt_logbl_test.c - Test __compiler_rt_logbl ---------------===// // // The LLVM Compiler Infrastructure |