diff options
| author | Will Dietz <wdietz2@illinois.edu> | 2012-12-31 06:36:44 +0000 |
|---|---|---|
| committer | Will Dietz <wdietz2@illinois.edu> | 2012-12-31 06:36:44 +0000 |
| commit | f359dea95de4a17287d11052e9b552100c152287 (patch) | |
| tree | 772343eddc367b38fad94a3b5d1f66c4b8ab1655 | |
| parent | 9202515bf430858117d117d98136a865feb1a281 (diff) | |
| download | compiler-rt-f359dea95de4a17287d11052e9b552100c152287.tar.gz | |
[ubsan] Don't suggest casting to unsigned for unsigned unary minus overflow.
Fixed version of r171273.
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@171278 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/ubsan/lit_tests/Integer/negate-overflow.cpp | 9 | ||||
| -rw-r--r-- | lib/ubsan/ubsan_handlers.cc | 13 |
2 files changed, 16 insertions, 6 deletions
diff --git a/lib/ubsan/lit_tests/Integer/negate-overflow.cpp b/lib/ubsan/lit_tests/Integer/negate-overflow.cpp index e3beb6b57..2ee4f1011 100644 --- a/lib/ubsan/lit_tests/Integer/negate-overflow.cpp +++ b/lib/ubsan/lit_tests/Integer/negate-overflow.cpp @@ -1,7 +1,12 @@ -// RUN: %clang -fsanitize=signed-integer-overflow %s -o %t && %t 2>&1 | FileCheck %s +// RUN: %clang -fsanitize=signed-integer-overflow %s -o %t && %t 2>&1 | FileCheck %s --check-prefix=CHECKS +// RUN: %clang -fsanitize=unsigned-integer-overflow %s -o %t && %t 2>&1 | FileCheck %s --check-prefix=CHECKU int main() { + // CHECKS-NOT: runtime error + // CHECKU: negate-overflow.cpp:[[@LINE+2]]:3: runtime error: negation of 2147483648 cannot be represented in type 'unsigned int' + // CHECKU-NOT: cast to an unsigned -unsigned(-0x7fffffff - 1); // ok - // CHECK: negate-overflow.cpp:6:10: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself + // CHECKS: negate-overflow.cpp:[[@LINE+2]]:10: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself + // CHECKU-NOT: runtime error return -(-0x7fffffff - 1); } diff --git a/lib/ubsan/ubsan_handlers.cc b/lib/ubsan/ubsan_handlers.cc index 5e73c04ee..0303e4361 100644 --- a/lib/ubsan/ubsan_handlers.cc +++ b/lib/ubsan/ubsan_handlers.cc @@ -103,10 +103,15 @@ void __ubsan::__ubsan_handle_mul_overflow_abort(OverflowData *Data, void __ubsan::__ubsan_handle_negate_overflow(OverflowData *Data, ValueHandle OldVal) { - Diag(Data->Loc, DL_Error, - "negation of %0 cannot be represented in type %1; " - "cast to an unsigned type to negate this value to itself") - << Value(Data->Type, OldVal) << Data->Type; + if (Data->Type.isSignedIntegerTy()) + Diag(Data->Loc, DL_Error, + "negation of %0 cannot be represented in type %1; " + "cast to an unsigned type to negate this value to itself") + << Value(Data->Type, OldVal) << Data->Type; + else + Diag(Data->Loc, DL_Error, + "negation of %0 cannot be represented in type %1") + << Value(Data->Type, OldVal) << Data->Type; } void __ubsan::__ubsan_handle_negate_overflow_abort(OverflowData *Data, ValueHandle OldVal) { |