diff options
| author | Reid Kleckner <rnk@google.com> | 2019-02-27 23:38:44 +0000 |
|---|---|---|
| committer | Reid Kleckner <rnk@google.com> | 2019-02-27 23:38:44 +0000 |
| commit | 2081e3e82022d96dba0b548da788450081a2ab87 (patch) | |
| tree | 3816db03bf991031d65eaea643411d98e5578e51 /lib/sanitizer_common/sanitizer_common.h | |
| parent | 0679ae46f0e5a214dec9cab55ee7ffba159feb84 (diff) | |
| download | compiler-rt-2081e3e82022d96dba0b548da788450081a2ab87.tar.gz | |
[InstrProf] Use separate comdat group for data and counters
Summary:
I hadn't realized that instrumentation runs before inlining, so we can't
use the function as the comdat group. Doing so can create relocations
against discarded sections when references to discarded __profc_
variables are inlined into functions outside the function's comdat
group.
In the future, perhaps we should consider standardizing the comdat group
names that ELF and COFF use. It will save object file size, since
__profv_$sym won't appear in the symbol table again.
Reviewers: xur, vsk
Subscribers: eraman, hiraditya, cfe-commits, #sanitizers, llvm-commits
Tags: #clang, #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D58737
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@355044 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/sanitizer_common/sanitizer_common.h')
0 files changed, 0 insertions, 0 deletions