diff options
| author | Alexander Richardson <arichardson.kde@gmail.com> | 2019-08-26 16:22:04 +0000 |
|---|---|---|
| committer | Alexander Richardson <arichardson.kde@gmail.com> | 2019-08-26 16:22:04 +0000 |
| commit | e77e4130fb1d25c27e15994bcfe3d9f42cd7aa68 (patch) | |
| tree | 8e1c8e0c12537a0461a1f754809c57fd2cb4fd1b /test/asan/TestCases | |
| parent | 2e59427d2e766f51a35ac673e86f6fdb0e5d0f89 (diff) | |
| download | compiler-rt-e77e4130fb1d25c27e15994bcfe3d9f42cd7aa68.tar.gz | |
[asan_symbolize] Avoid blocking when llvm-symbolizer is installed as addr2line
Summary:
Currently, llvm-symbolizer will print -1 when presented with -1 and not
print a second line. In that case we will block for ever trying to read
the file name. This also happens for non-existent files, in which case GNU
addr2line exits immediate, but llvm-symbolizer does not (see
https://llvm.org/PR42754). While touching these lines, I also added some
more debug logging to help diagnose this and potential future issues.
Reviewers: kcc, eugenis, glider, samsonov
Reviewed By: eugenis
Subscribers: kubamracek, #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D65322
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@369924 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/asan/TestCases')
| -rw-r--r-- | test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp b/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp index 3f93122e9..057a4de14 100644 --- a/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp +++ b/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp @@ -1,4 +1,15 @@ // Test that asan_symbolize does not hang when provided with an non-existing // path. -// RUN: echo '#0 0xabcdabcd (%t/bad/path+0x1234)' | %asan_symbolize | FileCheck %s -// CHECK: #0 0xabcdabcd +// RUN: echo '#0 0xabcdabcd (%t/bad/path+0x1234)' | %asan_symbolize | FileCheck %s -check-prefix CHECK-BAD-FILE +// CHECK-BAD-FILE: #0 0xabcdabcd in ?? ??:0 +// CHECK-BAD-FILE-EMPTY: + +// Also test that asan_symbolize doesn't assert on an invalid address with a valid file: +// RUN: %clangxx_asan -O0 %s -o %t +// RUN: echo '#0 0xabcdabcd (%t+0x0)' | %asan_symbolize | FileCheck %s -check-prefix CHECK-BAD-ADDR +// CHECK-BAD-ADDR: #0 0xabcdabcd in ?? +// CHECK-BAD-ADDR-EMPTY: + +int main() { + return 0; +} |