diff options
| author | Dan Liew <dan@su-root.co.uk> | 2019-10-08 20:06:01 +0000 |
|---|---|---|
| committer | Dan Liew <dan@su-root.co.uk> | 2019-10-08 20:06:01 +0000 |
| commit | fc749b5cf3d06d3940f04fe69b7d3c66ca8a9368 (patch) | |
| tree | 7b9668c366f8e0956c1e900d558a742ddd84b1a9 /test/builtins/timing | |
| parent | 6b1ce8376c9177e9e67668d81a46580efab5130e (diff) | |
| download | compiler-rt-fc749b5cf3d06d3940f04fe69b7d3c66ca8a9368.tar.gz | |
Fix `compiler_rt_logbf_test.c` test failure for Builtins-i386-darwin test suite.
Summary:
It seems that compiler-rt's implementation and Darwin
libm's implementation of `logbf()` differ when given a NaN
with raised sign bit. Strangely this behaviour only happens with
i386 Darwin libm. For x86_64 and x86_64h the existing compiler-rt
implementation matched Darwin libm.
To workaround this the `compiler_rt_logbf_test.c` has been modified
to do a comparison on the `fp_t` type and if that fails check if both
values are NaN. If both values are NaN they are equivalent and no
error needs to be raised.
rdar://problem/55565503
Reviewers: rupprecht, scanon, compnerd, echristo
Subscribers: #sanitizers, llvm-commits
Tags: #llvm, #sanitizers
Differential Revision: https://reviews.llvm.org/D67999
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@374109 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/builtins/timing')
0 files changed, 0 insertions, 0 deletions