diff options
| author | Boyan Karatotev <boyan.karatotev@arm.com> | 2022-11-18 14:17:17 +0000 |
|---|---|---|
| committer | Boyan Karatotev <boyan.karatotev@arm.com> | 2022-12-01 16:17:24 +0000 |
| commit | e138400d1c19a561eaf9f23b0cadc07226684561 (patch) | |
| tree | 352587af53437c6c85a7e445a882834060c73c42 /services/std_svc | |
| parent | d3d2a5a484936a17a4425ea3634b1c2e64dac877 (diff) | |
| download | arm-trusted-firmware-e138400d1c19a561eaf9f23b0cadc07226684561.tar.gz | |
fix: unify fallthrough annotations
Compiling with -Wimplicit-fallthrough=3 (enabled by -Wextra) produces
many warnings about fallthrough comments either missing or being wrong.
Unify the comments so we comply with -Wextra.
Note that Coverity recommends against using the __attribute__ directive.
Also, zlib does not build with a higher value of -Wimplicit-fallthrough.
Finally, compilers strip comments before expanding macros. As such,
checkpatch's fallthrough annotation (or higher levels of the flag) isn't
really possible.
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>
Change-Id: I060cf4f8dc04c02cbb45cf4ceb69569a8369ccee
Diffstat (limited to 'services/std_svc')
| -rw-r--r-- | services/std_svc/spmd/spmd_main.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/services/std_svc/spmd/spmd_main.c b/services/std_svc/spmd/spmd_main.c index 7e6c89df3..afd0f2ea2 100644 --- a/services/std_svc/spmd/spmd_main.c +++ b/services/std_svc/spmd/spmd_main.c @@ -868,7 +868,8 @@ uint64_t spmd_smc_handler(uint32_t smc_fid, FFA_ERROR_NOT_SUPPORTED); } - /* Fall through to forward the call to the other world */ + /* Forward the call to the other world */ + /* fallthrough */ case FFA_MSG_SEND: case FFA_MSG_SEND_DIRECT_RESP_SMC64: case FFA_MEM_DONATE_SMC32: @@ -908,7 +909,8 @@ uint64_t spmd_smc_handler(uint32_t smc_fid, spmd_spm_core_sync_exit(0ULL); } - /* Fall through to forward the call to the other world */ + /* Forward the call to the other world */ + /* fallthrough */ case FFA_INTERRUPT: case FFA_MSG_YIELD: /* This interface must be invoked only by the Secure world */ |