summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew McRae <amcrae@google.com>2022-03-16 20:35:02 +1100
committerCommit Bot <commit-bot@chromium.org>2022-03-16 22:39:29 +0000
commit5908f8785d80e858c4fa95bb8c660bf7254982d5 (patch)
treeb6ac34c89f547279083096a91a479cb2121c2de1
parent70723f7c82ac745a031869de476d5835633c89b2 (diff)
downloadchrome-ec-5908f8785d80e858c4fa95bb8c660bf7254982d5.tar.gz
ap_pwrseq: Clear default debug flags.
Reduce the noise by not enabling all the debug mask bits. powerindebug can be used to set the mask as desired. BUG=b:201000950 TEST=xmake build nivviks BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Iae56960ecbf0bbd653df9242999aa6ed2e2cc253 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3528454 Reviewed-by: Divya S Sasidharan <divya.s.sasidharan@intel.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
-rw-r--r--zephyr/subsys/ap_pwrseq/x86_non_dsx_common_pwrseq_sm_handler.c1
-rw-r--r--zephyr/test/ap_power/src/signals.c6
2 files changed, 6 insertions, 1 deletions
diff --git a/zephyr/subsys/ap_pwrseq/x86_non_dsx_common_pwrseq_sm_handler.c b/zephyr/subsys/ap_pwrseq/x86_non_dsx_common_pwrseq_sm_handler.c
index d712bb008a..f980f91d52 100644
--- a/zephyr/subsys/ap_pwrseq/x86_non_dsx_common_pwrseq_sm_handler.c
+++ b/zephyr/subsys/ap_pwrseq/x86_non_dsx_common_pwrseq_sm_handler.c
@@ -408,7 +408,6 @@ static int pwrseq_init(const struct device *dev)
power_signal_init();
/* TODO: Define initial state of power sequence */
LOG_DBG("Init pwr seq state");
- power_set_debug(0xFFFFFF);
init_pwr_seq_state();
/* Create power sequence state handler core function thread */
create_pwrseq_thread();
diff --git a/zephyr/test/ap_power/src/signals.c b/zephyr/test/ap_power/src/signals.c
index 8bbf88c2a9..432b28042b 100644
--- a/zephyr/test/ap_power/src/signals.c
+++ b/zephyr/test/ap_power/src/signals.c
@@ -299,11 +299,17 @@ ZTEST(signals, test_signal_mask)
*/
ZTEST(signals, test_debug_mask)
{
+ power_signal_mask_t old;
power_signal_mask_t dm = 0xDEADBEEF;
+ old = power_get_debug();
power_set_debug(dm);
zassert_equal(dm, power_get_debug(),
"Debug mask does not match set value");
+ /*
+ * Reset back to default.
+ */
+ power_set_debug(old);
}
/**