diff options
| author | Vadim Bendebury <vbendeb@chromium.org> | 2021-10-21 09:10:56 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-11-05 23:54:36 +0000 |
| commit | cc6e3832eb63ffb58de9054fb38498f1e109955b (patch) | |
| tree | c175f9ead57f38d9fa4e2c9064e492edf4cb93e0 | |
| parent | 4c9dac33088946de372d977cbb09cff2fb51ed4f (diff) | |
| download | chrome-ec-2.94_pp.0.tar.gz | |
board_id: fix an incorrect offset calculationv2.94_pp.0
The INFO_BOARD_ID_OFFSET value includes the offset of the board ID
field, there is no need to add the field offset again.
This incorrect calculation is not a problem, because the offset of the
'bid' field is zero, but the logic is wrong.
BUG=none
TEST=board ID value is still reported properly.
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Change-Id: I3e7061a930d751d2cf13113b1e519e8f976195bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3236754
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>
(cherry picked from commit 2b948afb28d0674eebb4dc0ece088fbf95f6a142)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3265225
Tested-by: Mary Ruthven <mruthven@chromium.org>
Auto-Submit: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
Commit-Queue: Vadim Sukhomlinov <sukhomlinov@chromium.org>
| -rw-r--r-- | chip/g/board_id.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chip/g/board_id.c b/chip/g/board_id.c index c7613dd3bd..cc2b7ebfaa 100644 --- a/chip/g/board_id.c +++ b/chip/g/board_id.c @@ -186,8 +186,7 @@ static int write_board_id(struct board_id *id) flash_info_write_enable(); /* Write Board ID */ - rv = flash_info_physical_write(INFO_BOARD_ID_OFFSET + - offsetof(struct info1_board_space, bid), + rv = flash_info_physical_write(INFO_BOARD_ID_OFFSET, sizeof(*id), (const char *)id); if (rv != EC_SUCCESS) CPRINTS("%s: write failed", __func__); |