diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2022-04-08 15:11:36 +0000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-04-09 02:38:28 +0000 |
| commit | 1d0617d7af7f85ae6d2a1778211f426b547b8a4e (patch) | |
| tree | f936137bb5a6444adaed07f34de06c55f16c2216 | |
| parent | 29aabfe8e3d3573d8702f27bb8948118bd8b78ef (diff) | |
| download | chrome-ec-1d0617d7af7f85ae6d2a1778211f426b547b8a4e.tar.gz | |
ectool/battery: Print discharging after the current
Currently, battery command prints the charge & discharge current without
a sign. This patch makes the command print 'discharging' after the
current value for clarification.
localhost ~ # ectool battery
...
Present current 782 mA (discharging)
BUG=b:227275730, b:213130539
BRANCH=None
TEST=On Atlas. See above
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: Ic1c87c721d128eaf25021c077aa6daa18f197fd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3577987
Reviewed-by: Andrew McRae <amcrae@google.com>
| -rw-r--r-- | util/ectool.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/util/ectool.c b/util/ectool.c index af116160e5..31e0f07631 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -7957,6 +7957,7 @@ int cmd_battery(int argc, char *argv[]) int rv, val; char *e; int index = 0; + uint8_t flags; if (argc > 2) { fprintf(stderr, "Usage: %s [index]\n", argv[0]); @@ -7983,6 +7984,8 @@ int cmd_battery(int argc, char *argv[]) return -1; } + flags = read_mapped_mem8(EC_MEMMAP_BATT_FLAG); + printf("Battery info:\n"); rv = read_mapped_string(EC_MEMMAP_BATT_MFGR, batt_text, @@ -8035,15 +8038,15 @@ int cmd_battery(int argc, char *argv[]) val = read_mapped_mem32(EC_MEMMAP_BATT_RATE); if (!is_battery_range(val)) goto cmd_error; - printf(" Present current %u mA\n", val); + printf(" Present current %u mA%s\n", val, + flags & EC_BATT_FLAG_DISCHARGING ? " (discharging)" : ""); val = read_mapped_mem32(EC_MEMMAP_BATT_CAP); if (!is_battery_range(val)) goto cmd_error; printf(" Remaining capacity %u mAh\n", val); - val = read_mapped_mem8(EC_MEMMAP_BATT_FLAG); - print_battery_flags(val); + print_battery_flags(flags); return 0; cmd_error: |