diff options
| author | Sam Hurst <shurst@google.com> | 2019-11-21 13:26:02 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-12-23 15:07:22 +0000 |
| commit | 28eaa6d6976986f3309aa2453632c71c818ea0fa (patch) | |
| tree | ad0dd5f5cfbd65a1bec36846a8eb38d7721fc34d | |
| parent | 86aa2d8ce08af4269491b73c76f72ea438aa14c8 (diff) | |
| download | chrome-ec-28eaa6d6976986f3309aa2453632c71c818ea0fa.tar.gz | |
TCPMv2: Fixed the pointer problem with decoding SRC_CAP PDO
A pointer to the PDO was getting incorrectly incremented,
causing an unknown value to be sent to the pe_update_pdo_flags
function.
BUG=chromium:1027252
BRANCH=none
TEST=make -j buildall
Plugged in an apple dock and verified that the PDO
was being correctly decoded.
Change-Id: I06f11aad0043f63ef43f75beccf48241f739ae46
Signed-off-by: Sam Hurst <shurst@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1928794
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1979563
Tested-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org>
| -rw-r--r-- | common/usbc/usb_pe_drp_sm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/usbc/usb_pe_drp_sm.c b/common/usbc/usb_pe_drp_sm.c index 5c11f6c4d9..590a72640d 100644 --- a/common/usbc/usb_pe_drp_sm.c +++ b/common/usbc/usb_pe_drp_sm.c @@ -1882,7 +1882,7 @@ static void pe_snk_evaluate_capability_entry(int port) pe[port].src_cap_cnt = num; for (i = 0; i < num; i++) - pe[port].src_caps[i] = *pdo++; + pe[port].src_caps[i] = pdo[i]; /* src cap 0 should be fixed PDO */ pe_update_pdo_flags(port, pdo[0]); |