diff options
| author | Jimmy Lin <jimmy.lin@quantatw.com> | 2015-08-21 16:49:28 +0800 |
|---|---|---|
| committer | ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> | 2015-08-25 06:48:35 +0000 |
| commit | 3acdf9e0b45e1e1bef60fff4a2af864121fdc723 (patch) | |
| tree | 73e5946dc93abf2779e8069d9bb02ecd64e245b9 | |
| parent | a73938dc4363bb9e10fe2a7813ca7da337cb4a55 (diff) | |
| download | chrome-ec-3acdf9e0b45e1e1bef60fff4a2af864121fdc723.tar.gz | |
Gnawty: Fix Battery LED is off after disconnect battery
BUG=chrome-os-partner:44327
BRANCH=gnawty
TEST=
STEP1.Start with having AC unplugged and battery disconnected and DUT is
completely in power off
STEP2.Plug AC back while battery is disconnecting
STEP3.Check Battery LED is blinking in orange 1 sec on and 1 sec
off instead of in off.
Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com>
Change-Id: I090c151f08bdabfd816354b3dfe107e525a5f9c1
Reviewed-on: https://chromium-review.googlesource.com/295004
Tested-by: 挺倫 林 <jimmy.lin@quantatw.com>
Reviewed-by: Mohammed Habibulla <moch@google.com>
Reviewed-by: 挺倫 林 <jimmy.lin@quantatw.com>
Commit-Queue: 挺倫 林 <jimmy.lin@quantatw.com>
| -rw-r--r-- | board/gnawty/led.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/board/gnawty/led.c b/board/gnawty/led.c index aefdeb9f95..84fe458e08 100644 --- a/board/gnawty/led.c +++ b/board/gnawty/led.c @@ -144,11 +144,12 @@ static void battery_led(void) if (!led_auto_control_is_enabled(EC_LED_ID_BATTERY_LED)) return; - /* If Battery critical Low, blink orange, 50% duty cycle, - * 2 sec period. + /* If Battery charging error or critical Low, blink orange, + * 50% duty cycle, 2 sec period. */ - if (!extpower_is_present() && chipset_in_state(CHIPSET_STATE_ON) && - (batt.state_of_charge <= CONFIG_BATTERY_LEVEL_CRITICAL)) { + if ((!extpower_is_present() && chipset_in_state(CHIPSET_STATE_ON) && + (batt.state_of_charge <= CONFIG_BATTERY_LEVEL_CRITICAL)) || + (chstate == PWR_STATE_ERROR)) { set_color_battery_led((battery_ticks & 0x4) ? LED_ORANGE : LED_OFF); return; |