diff options
| author | Jett Rink <jettrink@chromium.org> | 2020-10-29 16:46:54 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-10-30 02:08:51 +0000 |
| commit | 77647ae24a7118aac93449bc88f601a6c09290b1 (patch) | |
| tree | d888d57223a41185f8994122a15018a04819055c | |
| parent | 28103bb44ee8652d9b8f6b9bce09f04cce89f1d0 (diff) | |
| download | chrome-ec-77647ae24a7118aac93449bc88f601a6c09290b1.tar.gz | |
zephyr: use gpio_pin_set_raw directly
Use the helper function, gpio_pin_set_raw, instead of the port function
directly in order to avoid shifting the bit number. This makes the get
and set API use similar APIs.
BRANCH=none
BUG=none
TEST=gpioget and gpioset still work on volteer
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I9eb68e8d66113f6a07a182b8af133cdf808f5cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2508328
Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
| -rw-r--r-- | zephyr/shim/src/gpio.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/zephyr/shim/src/gpio.c b/zephyr/shim/src/gpio.c index 181b9d71a8..d0ffcdc373 100644 --- a/zephyr/shim/src/gpio.c +++ b/zephyr/shim/src/gpio.c @@ -117,15 +117,7 @@ const char *gpio_get_name(enum gpio_signal signal) void gpio_set_level(enum gpio_signal signal, int value) { - int rv; - - if (value != 0) { - rv = gpio_port_set_bits_raw(data[signal].dev, - BIT(configs[signal].pin)); - } else { - rv = gpio_port_clear_bits_raw(data[signal].dev, - BIT(configs[signal].pin)); - } + int rv = gpio_pin_set_raw(data[signal].dev, configs[signal].pin, value); if (rv < 0) { LOG_ERR("Cannot write %s (%d)", configs[signal].name, rv); |