diff options
| author | Namyoon Woo <namyoon@chromium.org> | 2019-10-04 09:26:59 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-10-07 22:39:14 +0000 |
| commit | 87d1b1904dc58fbadd21cd5c7c6b03da2e42d077 (patch) | |
| tree | 1e1534d92bcd3e1a2d0f426f528fb1d4baa1c5aa | |
| parent | bd381a6ae29a4ed62d5519f2d2b3ea05ce17f23e (diff) | |
| download | chrome-ec-87d1b1904dc58fbadd21cd5c7c6b03da2e42d077.tar.gz | |
cr50: correct the comment on ENTERING_RW in gpio.inc
The previous comments were not correct. ENTERING_RW is not a GPIO
at H1. The reason of marking it unimplemented in gpio.inc is to
avoid the compile error from cros FW common module.
BUG=None
BRANCH=cr50
TEST=make buildall.
Change-Id: Ieecbc9128e4071accbe4408d41ec51cefb68cffc
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1842031
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
| -rw-r--r-- | board/cr50/gpio.inc | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/board/cr50/gpio.inc b/board/cr50/gpio.inc index f899272166..73a7360de1 100644 --- a/board/cr50/gpio.inc +++ b/board/cr50/gpio.inc @@ -190,8 +190,11 @@ GPIO(I2CS_SDA, PIN(0, 14), GPIO_INPUT) */ GPIO(EC_TX_CR50_RX_OUT, PIN(0, 15), GPIO_ODR_HIGH) -/* Unimplemented signals which we need to emulate for now */ -/* TODO(wfrichar): Half the boards don't use this signal. Take it out. */ +/* + * ENTERING_RW is not a GPIO in H1, but an input pin to RBOX module. + * However, we declare it as 'UNIMPLEMENTED' to avoid a compile error in + * common/system.c. + */ UNIMPLEMENTED(ENTERING_RW) /* |